fix: General Ledger translation issues (backport #27298)#46149
Closed
mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
Closed
fix: General Ledger translation issues (backport #27298)#46149mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
mergify[bot] wants to merge 1 commit intoversion-13-hotfixfrom
Conversation
* fix: remove translations from GL report options Options need not be translated, their display label gets translated client side. * fix: make group by options translatable * ci: semgrep rule for translated options in report Co-authored-by: Ankush Menat <ankush@iwebnotes.com> (cherry picked from commit fa819f2) # Conflicts: # .github/helper/semgrep_rules/report.yml # erpnext/accounts/report/general_ledger/general_ledger.py
Contributor
Author
|
Cherry-pick of fa819f2 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options of group_by filter are translated. Assertions were made against English sentences and hence would always return false in cases where English isn't the system language.
Solution: don't translate options server side. Only displayed labels are translated client side.
closes #27277
This is an automatic backport of pull request #27298 done by [Mergify](https://mergify.com).