fix: handle request failures due to internet#581
Closed
safwansamsudeen wants to merge 3 commits intomainfrom
Closed
fix: handle request failures due to internet#581safwansamsudeen wants to merge 3 commits intomainfrom
safwansamsudeen wants to merge 3 commits intomainfrom
Conversation
| ) | ||
| return ctx | ||
| } | ||
| if (ctx.error.message === 'Failed to fetch') { |
Contributor
There was a problem hiding this comment.
This error message is different in browsers.
Firefox:
Not a reliable way to detect network error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writer supports offline mode, so I need to be able to not toast about save failures if it's because of the internet.
In general, people should be able to differentiate between network failures and server failures. Right now frappe-ui just crashes in the error handling function.