Skip to content

Check EOL dates automatically#24

Merged
legoktm merged 5 commits intomainfrom
eol-checker
Jul 11, 2025
Merged

Check EOL dates automatically#24
legoktm merged 5 commits intomainfrom
eol-checker

Conversation

@eloquence
Copy link
Contributor

@eloquence eloquence commented Jun 24, 2025

EOL dates can be manually configured, or retrieved from endoflife.date's API. See eol.yaml.sample in this branch for an example.

As a nightly job: Using the token configured in https://github.com/freedomofpress/infrastructure/issues/5824, opens issues. Using write permission, commits an ICS calendar file to the main branch in this repo.

Resolves #23

Background

Ready for initial review - commits & issue creation should work once we configure the tokens. We'll need an ISSUES_TOKEN with access to any repos we want to be able to open issues in, and a PUSH_TOKEN with access to this repo.

Code written & co-generated with ChatGPT o3 and Claude Code. Example GitHub action run for generate-ics: https://github.com/freedomofpress/securedrop-dev/actions/runs/15887471512/job/44802858613

I've tested issue creation (including no duplication of existing issues) against a private repo. I've also tested calendar import via GCal.

Opens issues & commits an ICS calendar file to this repo
@eloquence eloquence marked this pull request as ready for review June 25, 2025 20:57
@eloquence eloquence force-pushed the eol-checker branch 5 times, most recently from e8fcf3f to e565ed1 Compare June 25, 2025 21:22
@eloquence eloquence changed the title [WIP] Check EOL dates automatically Check EOL dates automatically Jun 25, 2025
@eloquence eloquence force-pushed the eol-checker branch 3 times, most recently from fd61780 to 486a95a Compare June 25, 2025 22:29
@eloquence eloquence marked this pull request as draft June 25, 2025 22:33
@eloquence eloquence moved this to Ready to go in SecureDrop Jun 25, 2025
@eloquence eloquence moved this from Ready to go to Ready For Review in SecureDrop Jun 25, 2025
Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did a quick code review (didn't try it out), overall looks good! Did you already try loading an ICS from GitHub with Google Calendar? Or did you have some other integration/hosting in mind?

@legoktm legoktm moved this from Ready For Review to Under Review in SecureDrop Jul 8, 2025
@eloquence
Copy link
Contributor Author

Thanks @legoktm, I think I addressed your comments. I did previously successfully import the generated ICS file into GCal.

Thanks for pointing out that we don't need a push token! I've requested the ISSUES_TOKEN over in https://github.com/freedomofpress/infrastructure/issues/5824. Once we have that I think we can take this for a spin. We can keep the fedora-40 in for now to see if it'll successfully open an issue for that.

@eloquence eloquence force-pushed the eol-checker branch 2 times, most recently from 2bbf9db to b4ecf18 Compare July 9, 2025 23:07
@eloquence eloquence moved this from Under Review to Ready For Review in SecureDrop Jul 9, 2025
@eloquence eloquence marked this pull request as ready for review July 9, 2025 23:16
@eloquence
Copy link
Contributor Author

Thanks @legoktm, this should be ready for another pass. I've tested issue creation (freedomofpress/securedrop-workstation#1364); on running the job a second time, it also correctly detected an existing (closed) issue and did not re-create it. I've removed that Fedora 40 check now, since it doesn't tell us anything new, so it'll be a while til the issue creation job is expected to fire.

Copy link
Member

@legoktm legoktm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@legoktm legoktm merged commit 036d4ac into main Jul 11, 2025
@github-project-automation github-project-automation bot moved this from Ready For Review to Done in SecureDrop Jul 11, 2025
@legoktm legoktm deleted the eol-checker branch July 11, 2025 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Create SD Critical Deadlines Calendar (e.g. EOL dates)

2 participants