Merged
Conversation
Add support for direct private key + email authentication as a third, more user-friendly authentication method. Users can now authenticate using just GOOGLE_PRIVATE_KEY and GOOGLE_CLIENT_EMAIL environment variables instead of providing a full service account JSON file. Changes: - Add GOOGLE_PRIVATE_KEY + GOOGLE_CLIENT_EMAIL authentication option - Update validation to support the new authentication method - Add comprehensive validation for private key format and email - Update README with detailed documentation for all three auth methods - Update .env.example with the new authentication option - Make GOOGLE_PROJECT_ID optional for private key auth This provides users with three authentication options: 1. File path (GOOGLE_APPLICATION_CREDENTIALS) 2. Full JSON string (GOOGLE_SERVICE_ACCOUNT_KEY) 3. Private key + email (GOOGLE_PRIVATE_KEY + GOOGLE_CLIENT_EMAIL) - new
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new, simplified authentication method for Google service accounts using only the private key and client email, in addition to the existing file-based and JSON string methods. The documentation and environment configuration have been updated to reflect this new option, and validation logic has been enhanced to support and verify the new method.
Authentication method improvements:
GOOGLE_PRIVATE_KEYandGOOGLE_CLIENT_EMAIL, making setup easier for users who don't want to manage full JSON files. (src/utils/google-auth.ts)src/utils/google-auth.ts) [1] [2]Documentation and configuration updates:
README.mdto describe all three supported methods, including detailed instructions and caveats for the new private key method. [1] [2]README.md).env.example. (.env.example)