fix: only load dotenv in explicit development mode#121
Merged
freema merged 1 commit intofreema:mainfrom Apr 15, 2026
Merged
Conversation
The dotenv import guard used `NODE_ENV !== 'production'`, which caused dotenv to load in any non-production environment — including when running as an MCP stdio server (where NODE_ENV is typically unset). In the bundled ESM output, this produced stderr warnings that interfered with JSON-RPC communication over stdio, causing MCP clients to fail to connect. Change the condition to `NODE_ENV === 'development'` so dotenv only loads when explicitly opted in. Adds regression tests verifying dotenv behavior across NODE_ENV values. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NODE_ENV !== 'production', which caused dotenv to load in any non-production environment — including when running as an MCP stdio server whereNODE_ENVis typically unsetimport('dotenv')produced stderr warnings (e.g.,requirenot supported in ESM) that interfered with JSON-RPC communication over stdio, causing MCP clients like Claude Code to fail to connectNODE_ENV === 'development'so dotenv only loads when explicitly opted inTest plan
tests/unit/dotenv-loading.test.tswith 4 cases coveringNODE_ENVunset,production,test, anddevelopment🤖 Generated with Claude Code