Skip to content

chore: remove vendored antiflood-tokens and identity-management modules#3804

Merged
iduartgomez merged 1 commit intomainfrom
remove-vendored-email-modules
Apr 9, 2026
Merged

chore: remove vendored antiflood-tokens and identity-management modules#3804
iduartgomez merged 1 commit intomainfrom
remove-vendored-email-modules

Conversation

@iduartgomez
Copy link
Copy Markdown
Collaborator

Summary

Removes the `modules/antiflood-tokens/` and `modules/identity-management/` directories from freenet-core. These crates have been moved to the freenet-email repository (see freenet/mail#10), which is their only consumer.

These modules were never part of freenet-core's workspace `members` list — they lived in `modules/` as orphaned, independently-built crates with their own Makefiles, used only by freenet-email's legacy build pipeline.

What was removed

  • `modules/antiflood-tokens/` — nested workspace containing:
    • `contracts/token-allocation-record/` (freenet contract)
    • `delegates/token-generator/` (freenet delegate)
    • `interfaces/` (shared `freenet-aft-interface` crate)
    • standalone `Cargo.toml` (nested workspace) and `Makefile`
  • `modules/identity-management/` — freenet delegate + tool binary

Verification

`cargo check --workspace` compiles 236 crates clean after the removal — no dangling references anywhere in freenet-core (verified across all `.toml`, `.rs`, `.md`, `.sh`, `*.yml` files). The only references were self-referential Makefiles inside the deleted directories themselves.

Cross-references

Test plan

  • `cargo check --workspace` clean (236 crates)
  • CI build in freenet-core should be unaffected since these modules were never part of the main workspace

These crates have been moved to the freenet-email repository, which is
their only consumer (see freenet/mail#10). They were never
part of this workspace's `members` list — they lived in modules/ as
orphaned, independently-built crates referenced only by freenet-email's
legacy Makefile.

Removed:
  modules/antiflood-tokens/  (contracts/token-allocation-record,
                              delegates/token-generator, interfaces,
                              and the standalone Makefile/workspace)
  modules/identity-management/ (delegate, tool binary, Makefile)

Verified: `cargo check --workspace` compiles 236 crates clean from
this state — no dangling references anywhere in freenet-core.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 9, 2026

Rule Review: Clean deletion PR, no code violations

Rules checked: git-workflow.md, code-style.md
Files reviewed: 23 (all deletions — no new code introduced)

Warnings

None.

Info

  • commit message — The commit body conveys the required information (what, why, verification), but doesn't use the prescribed ## Problem / ## Solution / ## Testing / ## Fixes section headers from git-workflow.md. If the GitHub PR body also lacks these headers, it would technically be a format violation. The substance is there; only the markdown structure is informal. (rule: git-workflow.md — WHEN creating a PR)

This is a pure deletion PR removing orphaned, non-workspace vendored modules. No production code was added or modified, so code-style rules (.unwrap(), spawns, channels, retry loops, etc.) have nothing to apply to. The chore: commit prefix is correct for this type of change.


Rule review against .claude/rules/. WARNING findings block merge.

@iduartgomez iduartgomez added this pull request to the merge queue Apr 9, 2026
@iduartgomez iduartgomez removed this pull request from the merge queue due to a manual request Apr 9, 2026
@iduartgomez iduartgomez merged commit b738c92 into main Apr 9, 2026
11 checks passed
@iduartgomez iduartgomez deleted the remove-vendored-email-modules branch April 9, 2026 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant