Conversation
Owner
Author
|
For all the Firefox enjoyers around here FYI @a-kenji, @rti, @velramiir, @pinpox ;) |
a-kenji
approved these changes
Apr 28, 2024
Collaborator
a-kenji
left a comment
a-kenji
left a comment
There was a problem hiding this comment.
LGTM, one small question.
| #[derive(Debug, Deserialize)] | ||
| pub struct FirefoxBookmarksPluginSettings { | ||
| #[serde(default = "default_true")] | ||
| pub enable: bool, |
Collaborator
There was a problem hiding this comment.
Do we want them true, or false?
Owner
Author
There was a problem hiding this comment.
That is a good question. I was thinking true, as the brave browser plugins also are enabled by default. But setting it to true would technically be a breaking change. WDYT?
a-kenji
reviewed
Apr 28, 2024
Owner
Author
|
I've added a parser for the firefox |
Collaborator
|
@friedow, |
Owner
Author
|
Unlucky, then I'll have to copy the database the same way I did with brave. I'm on it ;) |
Owner
Author
|
I've duplicated the database on plugin start. @a-kenji wanna test again? |
Merged
friedow
added a commit
that referenced
this pull request
Jun 2, 2024
## Release Notes ### ✨ New Features * 💄 display bars to visualize cpu core usage by @friedow in #121 * ✨ `git_repositories`: add `zoxide` integration by @a-kenji in #111 * ✨ enable font-fallack for all entries by @friedow in #131 * 🌈 Allow setting colors via configuration by @pinpox in #141 * 😜 Gitmoji plugin by @friedow in #144 * 📑 Firefox bookmarks plugin by @friedow in #133 * 📜 Firefox History by @friedow in #152 ### 🐛 Fixed Bugs * 🐛 return false when file_name cannot convert to str by @prmadev in #123 * 🐛 filter empty plugins for calculating scroll offset by @friedow in #125 * 🐛 Add sort function to plugin trait by @a-kenji in #124 * 🐛 implement full desktop spec by @friedow in #120 * 🐛 fix initial sorting in a bunch of plugins by @friedow in #129 * 🐛: fix suspend command invocation by @a-kenji in #134 ### Maintenance * 📝 clarify wayland support by @a-kenji in #105 * 👷 remove magic-nix-cache action by @a-kenji in #106 * ✏️ Fix a small typo in the Readme by @a-kenji in #112 * 🚨 Implement various clippy suggestions by @a-kenji in #113 ### New Contributors * @prmadev made their first contribution in #123 * @pinpox made their first contribution in #141 **Full Changelog**: v1.0.0...v1.1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This finally adds a first plugin for firefox 🎉. With this you are able to search and open your firefox bookmarks. Bookmarks are sorted by the number of visits.
This closes #13!