[Repo Assist] fix: preserve declared properties when schema has both properties and additionalProperties

[github-actions]

🤖 This PR was created by Repo Assist, an automated AI assistant.

Summary

Fixes a bug where an OpenAPI schema object defining both properties and additionalProperties was compiled as a plain Map<string, T>, silently discarding all the explicitly declared named properties.

Root Cause

In DefinitionCompiler.fs, the guard for the dictionary path was:

| _ when
    resolvedType = Some JsonSchemaType.Object
    && not(isNull schemaObj.AdditionalProperties)
    -> // Dictionary

This condition fired whenever additionalProperties was present, regardless of whether the schema also had explicit properties. As a result, a schema like:

MyObj:
  type: object
  properties:
    name:
      type: string
  additionalProperties:
    type: integer

would produce Map<string, int> and the Name property would be inaccessible.

Fix

Added && (schemaObj.Properties |> isNull || schemaObj.Properties.Count = 0) to the guard, so the Map path is only taken when no explicit properties are declared. When both are present, the type falls through to compileNewObject(), which correctly produces a provided type with all declared properties.

This matches the pattern already used for the allOf/oneOf/anyOf single-reference cases (which also guard on Properties.Count = 0).

Trade-offs

The additionalProperties typing is not surfaced for the mixed case (same as before, and a known limitation of the current architecture). The named properties are now accessible via the generated type, which is the more useful outcome.

Test Status

• ✅ All 281 existing unit tests pass (SwaggerProvider.Tests)
• ✅ New regression test added: object with properties and additionalProperties compiles to object type not Map
• Format checked with dotnet fantomas --check

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@97143ac59cb3a13ef2a77581f929f06719c7402a

Generated by 🌈 Repo Assist, see workflow run. Learn more.

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@97143ac59cb3a13ef2a77581f929f06719c7402a

[Copilot]

Pull request overview

Fixes an OpenAPI schema compilation bug where type: object schemas that define both properties and additionalProperties were incorrectly compiled as Map<string, T>, dropping explicitly declared properties.

Changes:

• Tightened the “dictionary/Map” guard in DefinitionCompiler.fs to only apply when no explicit properties are declared.
• Added a regression test ensuring mixed properties + additionalProperties schemas compile to an object type and preserve declared properties.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
src/SwaggerProvider.DesignTime/DefinitionCompiler.fs	Prevents the dictionary compilation path when properties are present, preserving named fields.
tests/SwaggerProvider.Tests/Schema.ArrayAndMapTypeMappingTests.fs	Adds regression coverage for the mixed object schema case to avoid future regressions.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.