osu-lazer-bin: add derivation for Tachyon releases#264
osu-lazer-bin: add derivation for Tachyon releases#264fufexan merged 1 commit intofufexan:masterfrom
Conversation
Closes fufexan#263 Addresses fufexan#261 A bit overengineered, but this ensures that both release streams are properly updated, and only when necessary. Signed-off-by: tsrk. <tsrk@tsrk.me>
a74be7a to
7e18b08
Compare
|
Maybe worth noting that this would probably need a follow-up once ppy/osu#33575 gets merged. |
|
Doesn't this package assumes that both release streams will have the same dependencies all the time and will have to involve extra logic if lazer uses SDL2 and tachyon uses SDL3 for example. Or did i understand something wrong? |
|
We could technically bundle both SDL2 and SDL3 since for now you can switch between them with an envar. Should not be that hard, just an additional build input and path symlink at install should normally do the trick. It's unlikely that osu! will drastically change dependencies very often, if that ever occurs, this should be handled on a case by case basis. The discrepancy between both release streams will probably not last long enough to the point where the current state of the derivation will be a pain to maintain. |
As commented in fufexan#264 (comment) Signed-off-by: tsrk. <tsrk@tsrk.me>
As commented in #264 (comment) Signed-off-by: tsrk. <tsrk@tsrk.me>
|
Does this package replace our included libraries with system-wide ones? osu! intentionally statically links every dependency we need, so I'm curious why this is being done. In the past, we have applied fixes for ffmpeg4, and rejected other "official-like" releases from using system-wide/shared SDL2 libs due to issues users had with incompatible libraries. We've also used our fork of SDL2 for a period of time during which we had upstream fixes pending. I notice the same is being done with SDL3 above, which is even more "unstable" than SDL2 given it is the development target. |
|
Furthermore, I don't know about setting There is a reason we removed this flag in ppy/osu-deploy#164 Should I be making individual issues for these? I just looked at the files in this PR and was pretty shocked seeing how far this is being taken. |
|
@smoogipoo I don't remember the specifics of why we're replacing libraries, nor have I known about the removal of the I'll make a PR to clean everything up, ensuring no library replacement. Thanks for the heads-up. |
Closes #263
Addresses #261
A bit overengineered, but this ensures that both release streams are properly updated, and only when necessary.