Use resourceId from eventSource if it exists#418
Open
julienboulay wants to merge 1 commit intofullcalendar:mainfrom
Open
Use resourceId from eventSource if it exists#418julienboulay wants to merge 1 commit intofullcalendar:mainfrom
julienboulay wants to merge 1 commit intofullcalendar:mainfrom
Conversation
|
Thanks for the PR |
Member
|
thanks for this @julienboulay . i want to merge this. could you please first sign this? https://docs.google.com/forms/d/e/1FAIpQLScU-HzFWsMRe1YcC_flGjIFRV_xm8nzRz1bIzUzSOMoA3AevQ/viewform?c=0&w=1 |
Author
|
@arshaw : I've signed the agreement. Just one remark before merging. It seems that this code is obsolete and I could manage the resourceId with eventDataTransform. |
Member
|
thanks @julienboulay . i think this feature is still valuable. it's more elegant that using eventDataTransform |
Member
|
if you get a chance, could you write an automated test? https://github.com/fullcalendar/old-docs/blob/wiki/Automated-Tests.md |
dbc63c8 to
df17d58
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allow to add resourceId defined on an eventSource and propagate it to the eventDef.
Fixes issue https://github.com/fullcalendar/fullcalendar-scheduler/issues/124