(bug or feature?) Yellow skull when attacking blinking white skull player

[zebeleu]

Scenario:
Player A opens PK on Player B and stop attacking;
In 60 seconds Player A's skull will blink before it vanishes;
Player C attacks Player A while blinking skull;
Player C is currently getting a yellow skull on Player A;
^ I know in some version the outcome is Player C attacking Player A while blinking, without taking yellow skull. Not sure if it was pre-7.7

[fusion32]

This one is a bit tricky. Here is a sequence of what is going on:

1. A attacks B, gets white skull and stops attacking
2. A and B get out of combat at the same time after ~60 seconds, triggering TPlayer::ClearPlayerkillingMarks for both on the SAME ROUND, which clears their AttackedList and removes them from others AttackedList
3. Since the order creatures are processed by ProcessCreatures is arbitrary, either one could get out of combat before the other
4. If A gets out of combat before B, it works normally and B doesn't get a yellow skull
5. If B gets out of combat before A, then it will be removed from A->AttackedList and A->FormerAttackedList won't contain B
6. B attacks A, and A is added to B->AttackedList because of (5.) (A->IsAttacker(B, true) returns false)
7. B isn't set as an aggressor because A is a former aggressor and so the attack is justified (Victim->IsAggressor(true) returns true)

This is just an edge case but any out-of-combat player attacking a former aggressor would result in this behaviour. I agree this is a problem, since the former aggressor would now be able to freely attack the yellow skull player. I'll try to come up with something to patch this, but it seems like this bug was also in the original game.

Just to make it clear, an aggressor (white skull) will become a former aggressor for up to 5 seconds after leaving combat, while the skull icon is blinking.

[zebeleu]

This one is a bit tricky. Here is a sequence of what is going on:

1. A attacks B, gets white skull and stops attacking
2. A and B get out of combat at the same time after ~60 seconds, triggering TPlayer::ClearPlayerkillingMarks for both on the SAME ROUND, which clears their AttackedList and removes them from others AttackedList
3. Since the order creatures are processed by ProcessCreatures is arbitrary, either one could get out of combat before the other
4. If A gets out of combat before B, it works normally and B doesn't get a yellow skull
5. If B gets out of combat before A, then it will be removed from A->AttackedList and A->FormerAttackedList won't contain B
6. B attacks A, and A is added to B->AttackedList because of (5.) (A->IsAttacker(B, true) returns false)
7. B isn't set as an aggressor because A is a former aggressor and so the attack is justified (Victim->IsAggressor(true) returns true)

This is just an edge case but any out-of-combat player attacking a former aggressor would result in this behaviour. I agree this is a problem, since the former aggressor would now be able to freely attack the yellow skull player. I'll try to come up with something to patch this, but it seems like this bug was also in the original game.

Just to make it clear, an aggressor (white skull) will become a former aggressor for up to 5 seconds after leaving combat, while the skull icon is blinking.

In my tests B would never get yellow skull on A (because it was his aggression?). Only C would get yellow skull in case he attacks A while blinking