FvwmPager: Always use ULONG_MAX for undefined color.#1298
Merged
ThomasAdam merged 1 commit intomainfrom Feb 22, 2026
Merged
Conversation
Since the color "black" is equal to "0", a false value, conditionals fail to use any user setting of "black" for different colors. This was fixed for the foreground color previously, but the problem still exists for background and balloon colors. This consistently uses `ULONG_MAX` to represent an undefined value for the default of different configurable colors in FvwmPager, so any user setting of `black` will correctly be used. Fixes #1297.
ThomasAdam
added
type:bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the color "black" is equal to "0", a false value, conditionals fail to use any user setting of "black" for different colors. This was fixed for the foreground color previously, but the problem still exists for background and balloon colors.
This consistently uses
ULONG_MAXto represent an undefined value for the default of different configurable colors in FvwmPager, so any user setting ofblackwill correctly be used.Fixes #1297.