This repository was archived by the owner on Mar 29, 2026. It is now read-only.
feat: Support browser-specific manifest generation for Chrome and Firefox#1067
Open
sun-yryr wants to merge 2 commits intofwouts:masterfrom
Open
feat: Support browser-specific manifest generation for Chrome and Firefox#1067sun-yryr wants to merge 2 commits intofwouts:masterfrom
sun-yryr wants to merge 2 commits intofwouts:masterfrom
Conversation
Owner
|
Hi @sun-yryr, sorry I no longer have the time to maintain this project. Please feel free to start maintaining a fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1066
This PR implements browser-specific manifest generation to support both Chrome and Firefox with Manifest V3:
manifest.template.jsonwith browser-specific keys using the pattern__{browser}__{key}(e.g.,__chrome__service_worker,__firefox__scripts)scripts/transform-manifest.jsthat processes the template and generates browser-specific manifest files during buildBROWSERenvironment variablebuild:chrome-mv3,build:firefox-mv3)build:allscript to build both browsersdist-chrome-mv3,dist-firefox-mv3)build:allinstead ofbuild/dist-*pattern to ignore all browser-specific dist directoriesTesting
Verified that the extension successfully fetches pull request lists on the following browsers:
Notes
release.ymlis not updated yet because I'm not familiar with the extension deployment process to Chrome Web Store and Firefox Add-ons.After this PR is merged, please update
release.ymlbefore releasing the extension.If helpful, here is a related reference: sun-yryr@89abd46