Skip to content
This repository was archived by the owner on Mar 29, 2026. It is now read-only.

feat: Support browser-specific manifest generation for Chrome and Firefox#1067

Open
sun-yryr wants to merge 2 commits intofwouts:masterfrom
sun-yryr:fix/support-firefox-mv3-without-release-ci
Open

feat: Support browser-specific manifest generation for Chrome and Firefox#1067
sun-yryr wants to merge 2 commits intofwouts:masterfrom
sun-yryr:fix/support-firefox-mv3-without-release-ci

Conversation

@sun-yryr
Copy link
Copy Markdown

@sun-yryr sun-yryr commented Dec 6, 2025

Summary

Fixes #1066

This PR implements browser-specific manifest generation to support both Chrome and Firefox with Manifest V3:

  • Added manifest template system: Created manifest.template.json with browser-specific keys using the pattern __{browser}__{key} (e.g., __chrome__service_worker, __firefox__scripts)
  • Implemented manifest transformer: Added scripts/transform-manifest.js that processes the template and generates browser-specific manifest files during build
  • Updated npm scripts:
    • Modified webpack config to support browser-specific builds via BROWSER environment variable
    • Added separate build scripts for Chrome and Firefox (build:chrome-mv3, build:firefox-mv3)
    • mv3 means Manifest V3
    • Added build:all script to build both browsers
    • Output directories are now browser-specific (dist-chrome-mv3, dist-firefox-mv3)
  • Updated CI: Modified CI workflow to use build:all instead of build
  • Updated .gitignore: Added /dist-* pattern to ignore all browser-specific dist directories

Testing

Verified that the extension successfully fetches pull request lists on the following browsers:

  • Floorp (12.7.0, Firefox 145.0.1)
  • Arc (1.122.0 (71105), Chromium Engine Version 142.0.7444.176)

Notes

release.yml is not updated yet because I'm not familiar with the extension deployment process to Chrome Web Store and Firefox Add-ons.

After this PR is merged, please update release.yml before releasing the extension.

If helpful, here is a related reference: sun-yryr@89abd46

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 6, 2025

CLA assistant check
All committers have signed the CLA.

@fwouts
Copy link
Copy Markdown
Owner

fwouts commented Mar 29, 2026

Hi @sun-yryr, sorry I no longer have the time to maintain this project. Please feel free to start maintaining a fork.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

current master branch does not work in Firefox

3 participants