Wip/redo forge by gabrielew · Pull Request #114 · gabrielew/otclient

gabrielew · 2025-10-19T21:34:03Z

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Behavior

Actual

Do this and that doesn't happens

Expected

Do this and that happens

Fixes

# (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Test Configuration:

Server Version:
Client:
Operating System:

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I checked the PR checks reports
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works

…feat/forge

@luanluciano93

* wip * feat: added analyser button * feat: WIP: exp analyzer UI * feat: WIP: XP analyzer window open/close * feat: wip: exp analyzer exp gain/exp hour * fix: mini window content on exp analyzer and setup on analyzer windows * fix: negative zero value * wip: start fixing cooldowns bar.. * fix: improve experience per hour calculation and handle edge cases * fix: update UI components in experience analyzer * feat: improve analyzer window handling * feat: adjust UI elements in game analyzer * feat: improve analyzer window handling * Update game_analyzer.lua * feat: enhance experience analyzer UI * feat: enhance experience analyzer UI * feat: enhance experience analyzer UI * feat: enhance experience analyzer UI * feat: enhance experience analyzer UI * Add new UI components for game analyzer features - Implemented a loot target setting window with input validation. - Created a miscellaneous tracker UI with various data displays. - Added party hunt analysis UI with leader and member information. - Developed a supply analyzer window to track looted items and their values. - Introduced an XP analyzer window to monitor XP gains and progress. - Added functionality for setting XP per hour targets with input validation. * feat: hide debug print statements in analyser and cooldown modules * feat: improve config saving with error handling and directory checks * feat: enhance game analyzer UI by hiding unnecessary buttons and adding context menu functionality * feat: update game analyzer UI by improving menu options and visibility handling for various components * mod: GraphUI variables locations * imp: text color and positions GraphUI * feat: adjust window height based on raw XP visibility * imp: Cyclopedia Items * feat: Drop Tracker list w/ Cyclopedia * feat: Drop Tracker list w/ Cyclopedia * feat: Drop Tracker + onKillTracker callback * feat: Drop Tracker + Cyclopedia Track * feat: Loot and Hunting Gold Values * fix: Cyclopedia Item Values and c * fix: fallback not needed * fix: Valuable Loot - Drop Tracker * feat: Loot Analyser 100% + Format change * feat: Enhance number formatting with K, KK * feat: Implement supply tracker callback to Lua * fix: values Loot and Supply * fix: XP graphs, DropTracker valuable loot pt1 * fix: DropTracker valuable loot pt2 * fix: Supply reset data * feat: Impact and Input Analyser pt1 * feat: Impact and Input Analyser pt2 * fix: Hunting and Input Analyser * feat: Impact and Input Analyser pt3 * feat: Impact and Input Analyser final * feat: Impact and Input Analyser final * feat: BossCooldown pt1 * feat: BossCooldown final * fix stuffs tks @luanluciano93 + partyHunt setup initial * Update PartyHuntAnalyser.lua * feat: Party analyser pt1 * test * rebuild1 * fix: partyAnalyser updates * Fix partyAnalyser updates * code refact * fix: party leave/join * Update PartyHuntAnalyser.lua * fix lag due to many requests * feat protocolparse Reset Party Hunt * fix correct protocol codes/params * feat: loot splitter + msising tutorial images * fix lootsplitter + hunting reset * fix 1 * refact-pt1-reseters * imp: debug/prints clean-up * remove fontbug * Update PartyHuntAnalyser.lua * refact 1 * Cyclopedia Items Price/value refact 1 * Cyclopedia Items Price/value refact 2 * Cyclopedia Items Price/value refact 3 * Cyclopedia Items Price/value refact 4 * Loot Analyser Refact 1 * Loot Analyser Refact 2 * Cyclopedia Items Price/value refact 5 * Hunting Analyser Refact 1 * Hunting Analyser Refact 2 * Refact Loot, Supply, Hunt, Cyclo FINAL. * Refact Market Data + Canary fix * Update analyser.lua * refact - remove misc Will be developed in future. Custom feature. * fix-cooldown-search * imp structs for better data handling * imp structs for better data handling pt2 * fix actions error --------- Co-authored-by: Matheus <matheussf.sc@gmail.com>

* feat: show mana shield circle * fix: empty mana circle * wip: statsbar * wip: mana shield * fix: mana shield bar * fix: mana shield show text * wip: is mage * Add mana shield bar to mage player HUD * fix: color

* Expand player state to 64-bit integer Changed player state variables and related methods from uint32_t to uint64_t to support additional state flags for newer client versions. Also updated protocol parsing and getter/setter signatures accordingly. Minor fix in UIWidget HTML layout to use std::max<int> for clarity. * Refactor player state handling to support 64-bit masks Updated player state logic to use 64-bit masks for better extensibility. Replaced bitwise operations with new helper functions for checking and iterating state changes. Updated related Lua and C++ code to use the new approach, improving maintainability and future-proofing state management.

The tooltip is not there yet because I can't find the packets.

ex: self.teste = { {arr = {1, 2, 3, 4, 5}} } <div *for="local teste in self.teste"> <div *for="local arr in teste.arr">{{arr}}</div> </div>

…ns (opentibiabr#1368)

…ntibiabr#1369)

…ation overhead (opentibiabr#1370)

…#1374)

…br#1382)

…pentibiabr#1382)" This reverts commit d0f068d.

This reverts commit 5933f8d.

…to wip/redo-forge

@slenderzn

- gradle updated to use Kotlin DSL - updated version of SDK and some dependencies - now when minimizing the client the sound stops playing in the background (thx @slenderzn) Co-authored-by: SlenderZN <62772580+slenderzn@users.noreply.github.com>

The code for the window from the game_cooldown module includes an apparent tooltip showing the spell name, but as of now it's always set to nil (progressRect:setTooltip(spellName) -> spellName is never defined).

Don't draw dead creatures

…/otclient into wip/redo-forge

chatgpt-codex-connector · 2025-10-19T21:39:15Z

💡 Codex Review

otclient/src/client/protocolgamesend.cpp

Lines 1393 to 1396 in c3ee774

    
           void ProtocolGame::sendOpenPortableForge() { 
        
               const auto& msg = std::make_shared<OutputMessage>(); 
        
               msg->addU8(Proto::ClientPreyRequest); 
        
               send(msg);

Use forging opcode when opening portable forge

The new sendOpenPortableForge client request writes Proto::ClientPreyRequest and sends it to the server. This opcode belongs to the Prey system and not to the forge feature (forge requests are introduced with Proto::ClientForgeEnter in the surrounding code). As a result, invoking this helper will send the wrong packet and the server will interpret it as a prey request instead of opening the portable forge. The request should use the forge opcode (ClientForgeEnter or whatever the server expects for opening the forge) to make the new UI functional.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

github-actions · 2025-11-19T02:51:24Z

This PR is stale because it has been open 45 days with no activity.

gabrielew and others added 30 commits October 10, 2025 07:56

Merge branch 'main' into feat/forge

de89c9e

init

00a8cbc

Merge branch 'html_fixes2' of https://github.com/mehah/otclient into …

46164f1

…feat/forge

fix: context error on setOutfit

034a55f

improve: check outfit draw

4475b6c

feat: circle mana shield (opentibiabr#1320)

e29a9cd

* feat: show mana shield circle * fix: empty mana circle * wip: statsbar * wip: mana shield * fix: mana shield bar * fix: mana shield show text * wip: is mage * Add mana shield bar to mage player HUD * fix: color

fix: bosstiary for client 13.10 (TFS)

bfd32ca

fix: blessing (opentibiabr#1355)

7579f84

The tooltip is not there yet because I can't find the packets.

fix(player): break circular include; minor isMage() perf tweak

e9c0f92

fix(html): preserve nested *for context

2dd672b

ex: self.teste = { {arr = {1, 2, 3, 4, 5}} } <div *for="local teste in self.teste"> <div *for="local arr in teste.arr">{{arr}}</div> </div>

perf: reimplement wrapText with single-pass layout and zero allocatio…

4e493bf

…ns (opentibiabr#1368)

perf: optimize BitmapFont rendering and text layout calculations (ope…

08ca6ab

…ntibiabr#1369)

perf: optimize calculateGlyphsPositions for lower CPU usage and alloc…

a7f43ec

…ation overhead (opentibiabr#1370)

feat: add initial flexbox support

b3a7a56

fix: missing parent variable access in nested *for loops

e51a004

fix: compile error

f65003f

fix: manashield errors in terminal and wasd walk problem (opentibiabr…

b2954cb

…#1374)

fix: battle lifebar (opentibiabr#1378)

a08849f

fix: textedit in html

32bfe1e

fix: text size on change font

abe7004

fix opentibiabr#1377

a986790

refactor: modernize codebase using ReSharper cleanup

5933f8d

fix(html): adjust font size when changing font dynamically using *font

9fa2093

Merge branch 'main' into feat/forge

c851aaa

chore: normalize code formatting across the entire project (opentibia…

d0f068d

…br#1382)

Revert "chore: normalize code formatting across the entire project (o…

fe940dd

…pentibiabr#1382)" This reverts commit d0f068d.

fix(html): margin

f03b2c0

Revert "refactor: modernize codebase using ReSharper cleanup"

3d89d6e

This reverts commit 5933f8d.

mehah and others added 27 commits October 18, 2025 19:41

improve

ce98f09

wip: fusion items

fdf71bf

Merge branch 'fix_whitespace' of https://github.com/mehah/otclient in…

ac5f8ba

…to wip/redo-forge

fix(html): white-space

5d62c98

improve: update android project

ceb2dd9

- gradle updated to use Kotlin DSL - updated version of SDK and some dependencies - now when minimizing the client the sound stops playing in the background (thx @slenderzn) Co-authored-by: SlenderZN <62772580+slenderzn@users.noreply.github.com>

fix: spell name tooltips in the cooldowns window

f5c98b4

The code for the window from the game_cooldown module includes an apparent tooltip showing the spell name, but as of now it's always set to nil (progressRect:setTooltip(spellName) -> spellName is never defined).

fix: add dead check to Creature draw method

8c2c9e4

Don't draw dead creatures

fix: button align

b89a423

init

6a8cc96

Update uiwidgethtml.cpp

8c7f200

Update uianchorlayout.cpp

912539b

Update uiwidgethtml.cpp

661fa7d

Update uiwidgethtml.cpp

a332081

Update htmlsample.css

ef7a88a

Merge branch 'main' of github.com:gabrielew/otclient into wip/redo-forge

c2e229a

wip: forge

43f73d8

Merge branch 'improve_absolute_like_html' of https://github.com/mehah…

ae42653

…/otclient into wip/redo-forge

Update uiwidget.h

2ec244b

Merge branch 'improve_absolute_like_html' of https://github.com/mehah…

10a183b

…/otclient into wip/redo-forge

fix: header alignment

60879ba

fix: content height

420b87e

Update uiwidgethtml.cpp

90471b0

fix: history footer

071f0a3

Merge branch 'improve_absolute_like_html' of https://github.com/mehah…

845ee31

…/otclient into wip/redo-forge

refactor: remove unnecessary code

ceda8bf

chore: remove unnecessary files

b42dfef

feat: use enable feature

c3ee774

github-actions Bot added the Stale label Nov 19, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wip/redo forge#114

Wip/redo forge#114
gabrielew wants to merge 65 commits into
feat/forgefrom
wip/redo-forge

gabrielew commented Oct 19, 2025

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2025

Uh oh!

github-actions Bot commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Conversation

gabrielew commented Oct 19, 2025

Description

Behavior

Actual

Expected

Fixes

Type of change

How Has This Been Tested

Checklist

Uh oh!

chatgpt-codex-connector Bot commented Oct 19, 2025

💡 Codex Review

Uh oh!

github-actions Bot commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants