Exclude tag excludes even if an include tag matches#542
Open
brarcher wants to merge 2 commits intogabrielfalcao:masterfrom
Open
Exclude tag excludes even if an include tag matches#542brarcher wants to merge 2 commits intogabrielfalcao:masterfrom
brarcher wants to merge 2 commits intogabrielfalcao:masterfrom
Conversation
When running 'make' if one does not have sure or python-subunit installed it will fail. Adding these to the dependencies.
If a user passes in a tag for which no scenario should run, e.g. --tag=-A then the expectation is that no scenario with that tag would run. However, the previous behavior was to include a scenario if an inclusion tag matches regardless if an exclusion tag also matches. scenario with an inclusionary. For example, if a scenario's tags were: ['A', 'B'] and the user specified: --tag=-A --tag=B the scenario would run. This change changes the behavior of scenario filtering: 1) If there are inclusionary tags and none match, the scenario is rejected 2) If there are exclusionary tags and any match, the scenario is rejected 3) If there are ~ or ~- tags and none match, the scenario is rejected 4) If the above did not reject the scenario, it is accepted gabrielfalcao#498
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow exclusionary tags to omit scenarios
If a user passes in a tag for which no scenario should run, e.g.
--tag=-A
then the expectation is that no scenario with that tag would run.
However, the previous behavior was to include a scenario if an
inclusion tag matches regardless if an exclusion tag also matches.
scenario with an inclusionary. For example, if a scenario's
tags were:
['A', 'B']
and the user specified:
--tag=-A --tag=B
the scenario would run.
This change changes the behavior of scenario filtering:
#498