change remove_numbers_fun with change_numbers_fun#1
Open
MubashirullahD wants to merge 5 commits intogaganmanku96:masterfrom
Open
change remove_numbers_fun with change_numbers_fun#1MubashirullahD wants to merge 5 commits intogaganmanku96:masterfrom
MubashirullahD wants to merge 5 commits intogaganmanku96:masterfrom
Conversation
line 95 [0-9] changed to [0-9]+ "" to be replaced with 'number'. It is the processing step that Stanford's ML course took when building a spam classifier. I think it is a huge mistake to remove numbers altogether. Boolean remove_numbers changed to change_numbers as well.
It can be done in a single line. Replaced with space.
improve regex for html tag removal
Revert "improve regex for html tag removal"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
line 95
[0-9] changed to [0-9]+
"" to be replaced with 'number'.
It is the processing step that Stanford's ML course took when building a spam classifier. I think it is a huge mistake to remove numbers altogether.
Boolean remove_numbers changed to change_numbers as well.