Skip to content

Add Hollar and Incentives#2226

Merged
jvonasek merged 1 commit intomasterfrom
add-hollar
Apr 3, 2025
Merged

Add Hollar and Incentives#2226
jvonasek merged 1 commit intomasterfrom
add-hollar

Conversation

@jvonasek
Copy link
Copy Markdown
Collaborator

No description provided.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2025

Deploy Preview for testnet-hydra-app ready!

Name Link
🔨 Latest commit 989235b
🔍 Latest deploy log https://app.netlify.com/sites/testnet-hydra-app/deploys/67eea6f83c11110008290d9c
😎 Deploy Preview https://deploy-preview-2226--testnet-hydra-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
6 paths audited
Performance: 28 (🔴 down 1 from production)
Accessibility: 85 (🔴 down 1 from production)
Best Practices: 99 (🟢 up 3 from production)
SEO: 98 (🟢 up 2 from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2025

Deploy Preview for hydradx-storybook ready!

Name Link
🔨 Latest commit 989235b
🔍 Latest deploy log https://app.netlify.com/sites/hydradx-storybook/deploys/67eea6f8a5e80e000844c7f7
😎 Deploy Preview https://deploy-preview-2226--hydradx-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 20, 2025

Deploy Preview for edge-hydra-app ready!

Name Link
🔨 Latest commit 989235b
🔍 Latest deploy log https://app.netlify.com/sites/edge-hydra-app/deploys/67eea6f8d8f9260008828c6a
😎 Deploy Preview https://deploy-preview-2226--edge-hydra-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
6 paths audited
Performance: 25 (🟢 up 1 from production)
Accessibility: 84 (no change from production)
Best Practices: 99 (no change from production)
SEO: 97 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@jvonasek jvonasek changed the title Add hollar Add Hollar and Incentives Mar 21, 2025
@jvonasek jvonasek marked this pull request as ready for review April 2, 2025 14:41
Comment thread src/sections/lending/LendingReserveOverviewPage.tsx
Comment thread src/sections/lending/LendingReserveOverviewPage.tsx
Comment thread src/utils/evm.ts Outdated
Comment thread src/utils/evm.ts Outdated
Comment thread src/sections/lending/components/infoTooltips/FixedAPYTooltip.tsx Outdated
Comment thread src/sections/lending/components/incentives/GhoIncentivesCard.tsx
Comment thread src/sections/lending/store/poolSelectors.ts Outdated
Comment thread src/sections/lending/ui/reserve-overview/gho/GhoReserveConfiguration.tsx Outdated
@jvonasek
Copy link
Copy Markdown
Collaborator Author

jvonasek commented Apr 3, 2025

ad. translations: I added the texts to translations.json, however AAVE has texts directly in the code, so a lot of copied code might still have untranslated strings, there is a lot of AAVE files, so some texts were left as is and we are moving the texts as we go.

@jvonasek jvonasek requested a review from radoslavcleevio April 3, 2025 11:32
@radoslavcleevio
Copy link
Copy Markdown
Contributor

ad. translations: I added the texts to translations.json, however AAVE has texts directly in the code, so a lot of copied code might still have untranslated strings, there is a lot of AAVE files, so some texts were left as is and we are moving the texts as we go.

Juraj said it doesnt matter so I guess keep old code untranslated.

@jvonasek jvonasek merged commit 74156c1 into master Apr 3, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants