Skip to content

Migrate AWS SDK to v2#874

Merged
ishan16696 merged 5 commits intogardener:masterfrom
vpnachev:enh/migrate-aws-sdk-to-v2
May 23, 2025
Merged

Migrate AWS SDK to v2#874
ishan16696 merged 5 commits intogardener:masterfrom
vpnachev:enh/migrate-aws-sdk-to-v2

Conversation

@vpnachev
Copy link
Member

@vpnachev vpnachev commented May 5, 2025

How to categorize this PR?
/area security ipcei
/kind enhancement
/label ipcei/workload-identity

What this PR does / why we need it:
Migrate AWS SDK to v2

Which issue(s) this PR fixes:
Fixes #838

Special notes for your reviewer:
Part of gardener/gardener#9586
Release note:

AWS SDK has been upgraded to v2.

@vpnachev vpnachev requested a review from a team as a code owner May 5, 2025 15:52
@gardener-robot gardener-robot added needs/review Needs review area/ipcei IPCEI (Important Project of Common European Interest) area/security Security related kind/enhancement Enhancement, improvement, extension labels May 5, 2025
@gardener-robot
Copy link

@vpnachev Label ipcei/workload-identity does not exist.

@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 5, 2025
@gardener-robot gardener-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs/second-opinion Needs second review by someone else labels May 5, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 5, 2025
@gardener-robot
Copy link

@vpnachev Label ipcei/workload-identity does not exist.

@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels May 5, 2025
@ishan16696
Copy link
Member

/assign

Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few nits:

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label May 20, 2025
@vpnachev vpnachev requested a review from ishan16696 May 20, 2025 15:04
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 20, 2025
@gardener-robot-ci-1 gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label May 20, 2025
@ishan16696
Copy link
Member

ishan16696 commented May 21, 2025

I have performed these tests with/without object lock enabled S3 bucket. Everything works fine

Restoration tests:

  • Restoration functionality of backup-restore should work with buckets which don't have bucket/object lock enabled (Backward compatibility).
  • Restoration functionality of backup-restore should work with buckets which have both versioned immutable as well as mutable, non-versioned snapshots present.
  • Restoration functionality of backup-restore should work with buckets which have only immutable versioned snapshots(full as well as delta) present.
  • Restoration functionality of backup-restore should work when attacker corrupted/deleted immutable versioned snapshots present in bucket.

To ignore the snapshots:

  • support of skipping/ignoring of any snapshot in an object lock enabled S3 bucket.

For Garbage collection of snapshots:

  • Backward compatibility with buckets which don't have immutability enabled.
  • GC should work with buckets which have both immutable as well as non immutable objects.
  • GC should work with buckets which have only immutable objects.

@ishan16696
Copy link
Member

I have tested the copy-backup tasks as well, basically coping the snapshots from source bucket(with object locked enabled ) to target bucket.

Copy link
Member

@ishan16696 ishan16696 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@ishan16696 ishan16696 merged commit dbc22d3 into gardener:master May 23, 2025
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label May 23, 2025
@vpnachev vpnachev deleted the enh/migrate-aws-sdk-to-v2 branch May 23, 2025 09:57
@Shreyas-s14 Shreyas-s14 modified the milestones: v0.36.0, v0.37.0 Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ipcei IPCEI (Important Project of Common European Interest) area/security Security related kind/enhancement Enhancement, improvement, extension needs/changes Needs (more) changes needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/review Needs review needs/second-opinion Needs second review by someone else size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate aws-sdk to aws-sdk-go-v2

6 participants