Introduce the `--store-endpoint-override` flag to pass storage endpoint configuration, instead of using the credential secret by renormalize · Pull Request #952 · gardener/etcd-backup-restore

renormalize · 2025-12-08T08:01:03Z

How to categorize this PR?

/area backup compliance robustness
/kind enhancement

What this PR does / why we need it:

This PR introduces changes to pass storage endpoint configuration through CLI flags, instead of information passed in the credential secret.

Passing endpoint information through credential files is deprecated, and this handling will be completely removed in v0.42.0.

This PR also removes all code in etcd-backup-restore that makes it aware that the storage backend is an emulator and not real infrastructure. etcd-backup-restore must not be aware of this information ideally.

Which issue(s) this PR fixes:
Fixes #943

Special notes for your reviewer:

Release note:

Storage endpoint configuration must now be passed through the `--store-endpoint-override` flag instead of a field in the credential secret. The older method of passing endpoint through credential files is now deprecated.

* `store-endpoint`'s value will be used to override the provider's default. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

* Endpoint override specified as a flag takes precedence over the override specified in the credential file. * Remove "chunk" suffixes that were added when the emulator was used. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

* Remove emulator support in the code, since the storage-endpoint override must be used for an emulator as the backend. * Endpoint override specified as a flag takes precedence over the override specified in the credential file. * Remove unit tests for functions which used to construct the `BlobServiceURL`. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

* Endpoint override specified as a flag takes precedence over the override specified in the credential file. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

* This flag is now removed since etcd-backup-restore must not be aware of the fact that it is running with an emulated storage backend. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

* `SnapstoreConfig.Endpoint` is renamed to `SnapstoreConfig.EndpointOverride` to better indicate to consumers that this field is an override, and not mandatory. * Rename the `store-endpoint` flag to `store-endpoint-override`. * Introduce a new function `configureClientOptions` for the GCS provider. This function checks the scheme of the endpoint of the GCS bucket, and if `http` is specified, it configures the client to work with an emulator. This is because `http` communication with GCS APIs is not allowed. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

pkg/types/snapstore.go

shreyas-s-rao

@renormalize thanks for addressing my comments.
/lgtm

gardener-prow · 2026-01-21T11:46:44Z

LGTM label has been added.

Details

Git tree hash: a0ac70818cb8a68301aa69ced99b3a993c940df1

…he bucket name to the override to form the URL instead. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

CaptainIRS

@renormalize thanks for addressing the review comments. I just have 1 follow-up comment, other than that, LGTM! PTAL, thanks.

hack/config/aws_config.sh

ishan16696

LGTM!!

gardener-prow · 2026-01-23T10:28:03Z

LGTM label has been added.

Details

Git tree hash: 4234f6e1ddd8b48a9efe8115f45a8cd8f6be787c

CaptainIRS

@renormalize thanks for making the logic in etcd-backup-restore agnostic to whether it is being run with emulators or not (like it ideally should be). LGTM!

hack/config/aws_config.sh

gardener-prow · 2026-01-23T10:45:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CaptainIRS, ishan16696, shreyas-s-rao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [ishan16696,shreyas-s-rao]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gardener-ci-robot · 2026-02-23T22:05:52Z

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

After 30d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 14d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as active with /lifecycle active
Mark this PR as fresh with /remove-lifecycle stale
Mark this PR as rotten with /lifecycle rotten
Close this PR with /close

/lifecycle stale

renormalize self-assigned this Dec 8, 2025

renormalize requested a review from a team as a code owner December 8, 2025 08:01

renormalize marked this pull request as draft December 9, 2025 05:18

renormalize force-pushed the endpoint branch 2 times, most recently from 15f0f44 to 0cda4cd Compare December 18, 2025 10:08

renormalize marked this pull request as ready for review December 18, 2025 10:08

renormalize mentioned this pull request Dec 18, 2025

Introduce BackupSpec.StoreSpec.EndpointOverride to override the object store's endpoint used by etcd-backup-restore gardener/etcd-druid#1236

Merged

renormalize force-pushed the endpoint branch from 0cda4cd to a37a790 Compare December 19, 2025 10:36

This comment was marked as outdated.

Sign in to view

gardener-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2026

CaptainIRS added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 3, 2026

renormalize added 5 commits January 5, 2026 14:30

Intoduce the store-endpoint flag.

051e40f

* `store-endpoint`'s value will be used to override the provider's default. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

Endpoint override for GCS is used when specified.

8849b98

* Endpoint override specified as a flag takes precedence over the override specified in the credential file. * Remove "chunk" suffixes that were added when the emulator was used. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

Endpoint override for S3 is used when specified.

73485f8

* Endpoint override specified as a flag takes precedence over the override specified in the credential file. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

Remove the IsEmulatorEnabled flag.

5e827ff

* This flag is now removed since etcd-backup-restore must not be aware of the fact that it is running with an emulated storage backend. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

renormalize force-pushed the endpoint branch from a37a790 to 5e827ff Compare January 5, 2026 09:18

renormalize mentioned this pull request Jan 6, 2026

Enhance the seedprovider webhook to specify EtcdSpec.BackupSpec.StoreSpec.Endpoint gardener/gardener-extension-provider-gcp#1273

Merged

ishan16696 added this to the v0.41.0 milestone Jan 12, 2026

shreyas-s-rao self-assigned this Jan 19, 2026

gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 19, 2026

Improve documentation and error messages.

8d48f85

Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

renormalize requested review from ishan16696 and shreyas-s-rao January 21, 2026 10:16

ishan16696 reviewed Jan 21, 2026

View reviewed changes

pkg/types/snapstore.go Show resolved Hide resolved

renormalize mentioned this pull request Jan 21, 2026

Remove support to pass backup bucket endpoint information through the credential file(s) #970

Open

shreyas-s-rao approved these changes Jan 21, 2026

View reviewed changes

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 21, 2026

gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 21, 2026

shreyas-s-rao removed their assignment Jan 21, 2026

renormalize added 4 commits January 22, 2026 16:49

Do not expect the ABS bucket name in the endpointOverride, append t…

7b85cd7

…he bucket name to the override to form the URL instead. Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

Update charts with --store-endpoint-override.

88e13fd

Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

Fix ci-e2e-kind-aws, ci-e2e-kind-azure, ci-e2e-kind-gcp.

fa9387e

Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

Enhance usage documentation with examples.

9617638

Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>

gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2026

gardener-prow bot requested a review from ishan16696 January 23, 2026 09:20

renormalize requested a review from CaptainIRS January 23, 2026 09:20

CaptainIRS reviewed Jan 23, 2026

View reviewed changes

hack/config/aws_config.sh Show resolved Hide resolved

ishan16696 approved these changes Jan 23, 2026

View reviewed changes

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2026

CaptainIRS approved these changes Jan 23, 2026

View reviewed changes

hack/config/aws_config.sh Show resolved Hide resolved

renormalize merged commit 1597dea into gardener:master Jan 23, 2026
26 of 28 checks passed

renormalize deleted the endpoint branch January 30, 2026 08:01

gardener-github-actions bot mentioned this pull request Feb 3, 2026

[ci:component:github.com/gardener/etcd-backup-restore:v0.40.0->v0.41.0] gardener/etcd-druid#1267

Merged

gardener-prow bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Feb 23, 2026

anveshreddy18 mentioned this pull request Feb 27, 2026

Remove deprecated support for passing endpoint via credential secrets #1000

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce the `--store-endpoint-override` flag to pass storage endpoint configuration, instead of using the credential secret#952

Introduce the `--store-endpoint-override` flag to pass storage endpoint configuration, instead of using the credential secret#952
renormalize merged 13 commits intogardener:masterfrom
renormalize:endpoint

renormalize commented Dec 8, 2025 •

edited

Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

shreyas-s-rao left a comment

Uh oh!

gardener-prow bot commented Jan 21, 2026

Uh oh!

CaptainIRS left a comment

Uh oh!

Uh oh!

ishan16696 left a comment

Uh oh!

gardener-prow bot commented Jan 23, 2026

Uh oh!

CaptainIRS left a comment

Uh oh!

Uh oh!

gardener-prow bot commented Jan 23, 2026

Uh oh!

Uh oh!

gardener-ci-robot commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

renormalize commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

shreyas-s-rao left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow bot commented Jan 21, 2026

Uh oh!

CaptainIRS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ishan16696 left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow bot commented Jan 23, 2026

Uh oh!

CaptainIRS left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gardener-prow bot commented Jan 23, 2026

Uh oh!

Uh oh!

gardener-ci-robot commented Feb 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

renormalize commented Dec 8, 2025 •

edited

Loading