Disable auth in embedded etcd#954
Conversation
|
Hi @Tomy2e. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
259e462 to
8ded394
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
8ded394 to
b60e1c8
Compare
|
Hi @ishan16696, my fix is ready for review 🙏 It looks like gitguardian secret scanner doesn't like the password I hardcoded in my test: Do not hesitate to let me know if there is something I can do to fix that. |
|
/assign |
ishan16696
left a comment
There was a problem hiding this comment.
thanks for the PR, few nits ....overall it looks good.
b60e1c8 to
e509318
Compare
Co-authored-by: Ishan Tyagi <42602577+ishan16696@users.noreply.github.com>
How to categorize this PR?
/area backup
/kind bug
What this PR does / why we need it:
This PR temporarily disables etcd authentication after starting the embedded etcd (if needed). It's enabled again before stopping the embedded etcd server.
Which issue(s) this PR fixes:
Fixes #950
Special notes for your reviewer:
Release note: