Skip to content

Migrate to golangci-lint/v2#1276

Open
renormalize wants to merge 2 commits intogardener:masterfrom
renormalize:golangci-lint.v2
Open

Migrate to golangci-lint/v2#1276
renormalize wants to merge 2 commits intogardener:masterfrom
renormalize:golangci-lint.v2

Conversation

@renormalize
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind task

What this PR does / why we need it:

  • Upgrade the golangci-lint tool to v2 in hack/tools.mk
  • Converts the .golangci.yaml file to v2
  • Fixes linting errors

Special notes for your reviewer:

cc @Shreyas-s14

Release note:

NONE

Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>
Signed-off-by: Saketh Kalaga <saketh.kalaga@sap.com>
@renormalize renormalize self-assigned this Feb 6, 2026
@renormalize renormalize requested a review from a team as a code owner February 6, 2026 04:57
@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/task General task cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Feb 6, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 6, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign shreyas-s-rao for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2026
@gardener-github-actions gardener-github-actions bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 6, 2026
@github-actions github-actions bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 6, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 6, 2026

@renormalize: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-druid-api-unit ef45951 link false /test pull-etcd-druid-api-unit

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@renormalize
Copy link
Member Author

Unit tests are failing, will update golangci-lint version in GitHub Actions as well.

@gardener-robot
Copy link

@Shreyas-s14 You have pull request review open invite, please check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/task General task needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants