Fix env var conflict issues with fake-gcs-server#1298
Fix env var conflict issues with fake-gcs-server#1298anveshreddy18 wants to merge 1 commit intogardener:masterfrom
Conversation
CaptainIRS
left a comment
There was a problem hiding this comment.
Could we instead just set enableServiceLinks to false in the fake-gcs deployment's pod spec since this is just a fsouza/fake-gcs-server-specific thing? I believe that one change should be sufficient to get this to work.
|
Thanks @CaptainIRS for the review, I did that originally and it worked, there is another way of explicitly setting FAKE_GCS_PORT to 4443 as well which also solves the problem, I tried both but they are essentially bandages to the root cause, and such issues can occur again if we don't solve the actual root of the issue which is the conflicting env var stemming from service name, so I instead chose to do that so we can solve it once and for all. |
CaptainIRS
left a comment
There was a problem hiding this comment.
Sounds good, thanks for the explanation!
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CaptainIRS The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
LGTM label has been added. DetailsGit tree hash: 2f361d08babf87ffc13580be93575e7d8e1656f8 |
…ith k8s injected env var FAKE_GCS_PORT
eb14e24 to
918df3f
Compare
|
@ishan16696 can you take a look at this PR for approval ? Thanks |
How to categorize this PR?
/area usability
/kind bug
What this PR does / why we need it:
This PR changes the
fake-gcsservice name tofake-gcs-serviceto avoid conflicts with k8s injected env varFAKE_GCS_PORTthat sets it totcp://PodIP:4443as it constructs this env var from the service name, The specificFAKE_GCS_PORTis important as thefsouza/fake-gcs-serverrefers to this env variable which resulted in the following error in the container:Changing the service name to
fake-gcs-servicefixes this as it no longer conflicts with the k8s ways of adding env vars for endpoints.Which issue(s) this PR fixes:
Fixes #
Checklist:
/docsfolder (if applicable)Special notes for your reviewer:
Release note: