Skip to content

Fix e2e tests with storage emulators by using EndpointOverride#1299

Open
anveshreddy18 wants to merge 1 commit intogardener:masterfrom
anveshreddy18:fix/e2e-tests-emulator-endpoint-override
Open

Fix e2e tests with storage emulators by using EndpointOverride#1299
anveshreddy18 wants to merge 1 commit intogardener:masterfrom
anveshreddy18:fix/e2e-tests-emulator-endpoint-override

Conversation

@anveshreddy18
Copy link
Member

@anveshreddy18 anveshreddy18 commented Feb 27, 2026

How to categorize this PR?

/area storage
/area testing
/kind test

What this PR does / why we need it:

This PR fixes the e2e tests with storage emulators by using EndpointOverride. The etcdbr PR#1000 removes the deprecation support for passing endpoint override through credentials, but the e2e tests in etcd-druid still use old way of passing it through secrets, this PR now updates that and updates documentation regarding that.

To be more specific, the e2e tests with storage emulators (Localstack, Azurite, FakeGCS) were broken because the test utilities were still generating deprecated secret fields (endpoint, domain, storageAPIEndpoint) that are no longer processed by etcd-backup-restore starting from 0.42.0

This change:

  • Updates test utilities to set EndpointOverride in the Etcd CR spec based on emulator environment variables
  • Removes deprecated field generation from GenerateBackupSecretData()
  • Fixes documentation with correct in-cluster service addresses
  • Adds detailed e2e setup instructions for each emulator

Which issue(s) this PR fixes:
Fixes #

Checklist:

  • Update documentation in the /docs folder (if applicable)
  • Add tests that cover your changes (if applicable)
    • Unit tests
    • Integration tests
    • E2E tests

Special notes for your reviewer:

Release note:

The e2e tests with storage emulators (Localstack, Azurite, FakeGCS) have been fixed w.r.t endpoint override.

@anveshreddy18 anveshreddy18 requested a review from a team as a code owner February 27, 2026 12:13
@anveshreddy18 anveshreddy18 self-assigned this Feb 27, 2026
@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Feb 27, 2026
@gardener-prow
Copy link

gardener-prow bot commented Feb 27, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign shreyas-s-rao for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 27, 2026
@anveshreddy18 anveshreddy18 added this to the v0.36.0 milestone Feb 27, 2026
@federated-github-access federated-github-access bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 27, 2026
@github-actions github-actions bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. and removed ok-to-test Indicates a non-member PR verified by an org member that is safe to test. labels Feb 27, 2026
@gardener gardener deleted a comment from gardener-prow bot Feb 27, 2026
@federated-github-access federated-github-access bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 27, 2026
@github-actions github-actions bot removed the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 27, 2026
@ishan16696 ishan16696 modified the milestones: v0.36.0, v0.37.0 Mar 2, 2026
@anveshreddy18 anveshreddy18 force-pushed the fix/e2e-tests-emulator-endpoint-override branch from 4754c2c to 046403d Compare March 3, 2026 06:59
@gardener-prow
Copy link

gardener-prow bot commented Mar 3, 2026

@anveshreddy18: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-druid-e2e-kind-recovery 046403d link true /test pull-etcd-druid-e2e-kind-recovery

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants