Fix e2e tests with storage emulators by using EndpointOverride#1299
Fix e2e tests with storage emulators by using EndpointOverride#1299anveshreddy18 wants to merge 1 commit intogardener:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
4754c2c to
046403d
Compare
|
@anveshreddy18: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
How to categorize this PR?
/area storage
/area testing
/kind test
What this PR does / why we need it:
This PR fixes the e2e tests with storage emulators by using EndpointOverride. The etcdbr PR#1000 removes the deprecation support for passing endpoint override through credentials, but the e2e tests in
etcd-druidstill use old way of passing it through secrets, this PR now updates that and updates documentation regarding that.To be more specific, the e2e tests with storage emulators (Localstack, Azurite, FakeGCS) were broken because the test utilities were still generating deprecated secret fields (endpoint, domain, storageAPIEndpoint) that are no longer processed by etcd-backup-restore starting from
0.42.0This change:
Which issue(s) this PR fixes:
Fixes #
Checklist:
/docsfolder (if applicable)Special notes for your reviewer:
Release note: