Fix compile-kit bugs for standalone kit repositories#524
Open
itsouvalas wants to merge 1 commit intov3.1.x-devfrom
Open
Fix compile-kit bugs for standalone kit repositories#524itsouvalas wants to merge 1 commit intov3.1.x-devfrom
itsouvalas wants to merge 1 commit intov3.1.x-devfrom
Conversation
- Allow compile-kit to work from kit source directories (not just deployment repos)
- Only query remote/local kit versions when in a deployment repository
- Skip version checks when compiling from standalone kit repos
- Fix filename truncation bug in Kit Compiler
- Corrected regex from s{/*}{/}r to s{/*$}{/}r to only match trailing slashes
- Removed incorrect +1 offset that was stripping first character of filenames
- Add graceful handling for missing files during compilation
- Check for undefined return from tar->add_files() instead of crashing
- Log warning and skip missing files instead of failing
These changes allow kit authors to run 'genesis compile-kit' directly from
their kit source repositories without needing a deployment repository context.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow compile-kit to work from kit source directories (not just deployment repos)
Fix filename truncation bug in Kit Compiler
Add graceful handling for missing files during compilation
These changes allow kit authors to run 'genesis compile-kit' directly from their kit source repositories without needing a deployment repository context.