Skip to content

Fix compile-kit bugs for standalone kit repositories#524

Open
itsouvalas wants to merge 1 commit intov3.1.x-devfrom
fix-compile-kit-bugs
Open

Fix compile-kit bugs for standalone kit repositories#524
itsouvalas wants to merge 1 commit intov3.1.x-devfrom
fix-compile-kit-bugs

Conversation

@itsouvalas
Copy link

  • Allow compile-kit to work from kit source directories (not just deployment repos)

    • Only query remote/local kit versions when in a deployment repository
    • Skip version checks when compiling from standalone kit repos
  • Fix filename truncation bug in Kit Compiler

    • Corrected regex from s{/}{/}r to s{/$}{/}r to only match trailing slashes
    • Removed incorrect +1 offset that was stripping first character of filenames
  • Add graceful handling for missing files during compilation

    • Check for undefined return from tar->add_files() instead of crashing
    • Log warning and skip missing files instead of failing

These changes allow kit authors to run 'genesis compile-kit' directly from their kit source repositories without needing a deployment repository context.

- Allow compile-kit to work from kit source directories (not just deployment repos)
  - Only query remote/local kit versions when in a deployment repository
  - Skip version checks when compiling from standalone kit repos

- Fix filename truncation bug in Kit Compiler
  - Corrected regex from s{/*}{/}r to s{/*$}{/}r to only match trailing slashes
  - Removed incorrect +1 offset that was stripping first character of filenames

- Add graceful handling for missing files during compilation
  - Check for undefined return from tar->add_files() instead of crashing
  - Log warning and skip missing files instead of failing

These changes allow kit authors to run 'genesis compile-kit' directly from
their kit source repositories without needing a deployment repository context.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant