Fixed potential bug where RNG isn't instantiated#540
Merged
neworderofjamie merged 2 commits intomasterfrom Oct 24, 2022
Merged
Conversation
Codecov ReportBase: 89.38% // Head: 89.34% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #540 +/- ##
==========================================
- Coverage 89.38% 89.34% -0.04%
==========================================
Files 73 73
Lines 10747 10767 +20
==========================================
+ Hits 9606 9620 +14
- Misses 1141 1147 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tnowotny
approved these changes
Oct 24, 2022
Member
tnowotny
left a comment
tnowotny
left a comment
There was a problem hiding this comment.
Looks sensible - nice catch.
Somehow I am having a deja-vu of having reviewed this one before but apparently not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If custom update variables were the only place in a model where an RNG was required for initialization, this wouldn't be detected and the model wouldn't compile. Have added extra unit tests and beefed up existing ones to test further up.