Merged
Conversation
tnowotny
approved these changes
Nov 7, 2022
Member
tnowotny
left a comment
tnowotny
left a comment
There was a problem hiding this comment.
Okaydoke ... love the spaghetti of options.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No idea what made me realise this but, while we had been passing
/mtomsbuildwhich allows projects to be build in parallel if they have no dependencies, it doesn't actually enable parallel compilation of C++ files. This PR turns the actual option we want on for all projects and, on my laptop, reduces the time taken to fully rebuild GeNN and backends from 48 to 16s.Sadly, it seems NVCC doesn't support this option so this is only really going to help life for developers using Windows (i.e. me) rather than help speed up compilation of generated code on Windows.