Merged
Conversation
Codecov ReportBase: 88.80% // Head: 89.31% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 88.80% 89.31% +0.51%
==========================================
Files 76 76
Lines 12358 12359 +1
==========================================
+ Hits 10975 11039 +64
+ Misses 1383 1320 -63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tnowotny
approved these changes
Feb 10, 2023
Member
tnowotny
left a comment
tnowotny
left a comment
There was a problem hiding this comment.
Yes, that looks like I would have expected. Mysterious that testing for batchsize > 1 is so elusive in the definition of the update group but indeed not much harm done to include numNeurons always.
Also Fabian has confirmed his code now works as he expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes here:
numNeuronsfield inNeuronPrevSpikeTimeUpdateGroupMergedrequired when model has batch size > 1. Not 100% sure why batch size isn't readily available in this constructor but unconditionally including the number of neurons is finegroup->prevSTandgroup->spkarenum_batches * num_neuronssize arrays so indices into both need to havebatchOffsetadding to them)I have also updated the feature test which nearly covered this to actually do so!
Fixes #564