Conversation
tnowotny
approved these changes
Feb 28, 2023
Member
tnowotny
left a comment
There was a problem hiding this comment.
Difficult business this but you have convinced me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fusing postsynaptic models, the decision on which can be fused was previously very conservative - any with state variables or extra global parameters were immediately excluded. This makes simulating large models with e.g. alpha synapses pretty much impossible so here I've relaxed the rules to match those used for fusing pre and postsynaptic updates from weight update models:
I think this makes sense 😄