Merged
Conversation
…custom update WU) groups
tnowotny
approved these changes
Mar 14, 2023
Member
tnowotny
left a comment
There was a problem hiding this comment.
Also looks good - not too many surprises here either.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #576 +/- ##
==========================================
+ Coverage 88.85% 88.92% +0.06%
==========================================
Files 76 76
Lines 12374 12393 +19
==========================================
+ Hits 10995 11020 +25
+ Misses 1379 1373 -6
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing EventProp, I got annoyed enough to implement #553. As well as improving usability, with large models where multiple synapse/neuron groups are actually getting merged together, this will improve performance as otherwise the "special function" unit on GPUs can get saturated by float->int conversions
Fixes #553