Merged
Conversation
* ``CustomUpdate`` detects whether it is per-neuron or not based on whether any variables or variable reference targets point to non SHARED_NEURON variables. If this is the case, SHARED_NEURON variables can only be read * Backend code for generating SHARED_NEURON updates
… as well as string
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #578 +/- ##
==========================================
- Coverage 89.36% 88.96% -0.41%
==========================================
Files 76 76
Lines 12393 12428 +35
==========================================
- Hits 11075 11056 -19
- Misses 1318 1372 +54
... and 5 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
tnowotny
approved these changes
Apr 18, 2023
Member
tnowotny
left a comment
tnowotny
left a comment
There was a problem hiding this comment.
What you say makes sense & I trust you that the code does as you say - also as usual I am afraid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearly #539 left a whole bunch of corner cases unhandled involving custom updates actually operating directly (rather than reducing into)
SHARED_NEURONvariables (i.e. duplicated across batches but shared across neurons) which I encountered when trying to use these in mlGeNN:CustomUpdate::isPerNeuron- this is set if any custom update variables or variable reference targets aren'tSHARED_NEURONSHARED_NEURONvariablesSHARED_NEURONvariablesAnd, as ever, I extended some feature tests to cover this behaviour as well as adding a couple of unit tests to check the
CustomUpdate::isPerNeuronlogic. On a similarly typical vein, there are also a couple of unrelated small fixes:SynapseGroup.matrix_typecan now be set from enumeration as well as by string (useful for mlGeNN connectivity type checking)SynapseGroup.get_var_valuesonKERNELconnectivity (useful when attempting to learn convolutions)