Ability to unload PyGeNN models#581
Merged
neworderofjamie merged 1 commit intomasterfrom May 15, 2023
Merged
Conversation
…NModel`` and unload shared library model
tnowotny
approved these changes
May 12, 2023
Member
tnowotny
left a comment
tnowotny
left a comment
There was a problem hiding this comment.
Ahem, sorry for the delay. This looks reasonable though I do not have the overview of whether everything is cleaned up that needs cleaning up. What would be a good test for this?
Contributor
Author
|
Will defer adding new tests until GeNN 5 when I reimplement feature tests in Python - raised #587 to remind me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyGeNN
GeNNModelobjects wrap both aModelSpecholding the model description and aSharedLibraryModelfor loading the dynamic library created from the generated code and executing it. This PR lets you 'unload' theSharedLibraryModelcomponent, freeing memory but allowing it to be easily re-loaded if required. This entails:Noneto prevent freed memory being accessedclosemethod toSharedLibraryModelwhich sets all pointers to variables etc tonullptr, empties the cache used to speed up access to functions and unloads the shared library.