Casting the incoming list-like "post_indices" to numpy array#597
Merged
neworderofjamie merged 2 commits intomasterfrom Sep 5, 2023
Merged
Casting the incoming list-like "post_indices" to numpy array#597neworderofjamie merged 2 commits intomasterfrom
neworderofjamie merged 2 commits intomasterfrom
Conversation
…t indexing into it with a numpy array is possible. Previously, there was an error if "post_indices" was a list because self.synapse_order is a numpy array and therefore cannot be used to index into this list.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #597 +/- ##
=======================================
Coverage 88.74% 88.74%
=======================================
Files 76 76
Lines 12490 12490
=======================================
Hits 11084 11084
Misses 1406 1406 ☔ View full report in Codecov by Sentry. |
Contributor
|
Nice! Personally I would do: pre_indices = np.asarray(pre_indices)
post_indices = np.asarray(post_indices)right at the top of the |
Member
Author
|
Ok, now changed ... and tested briefly on my sudoku code. It seems to work as well (as expected). |
neworderofjamie
approved these changes
Sep 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, there was an error if "post_indices" was a list because self.synapse_order is a numpy array and therefore cannot be used to index into this list.