Step 7 - Single PSM code string#612
Merged
neworderofjamie merged 4 commits intogenn_5from Jan 31, 2024
Merged
Conversation
tnowotny
approved these changes
Jan 31, 2024
Member
tnowotny
left a comment
There was a problem hiding this comment.
Yes, I think this is worth doing and makes things simpler and more sensible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the last syntax change I want to make. Previously, postsynaptic models had two code strings "decay code" and "apply input code" (the latter of which could also be configured via "custom converter code" in C++ for backward compatibility). This separation doesn't really make any sense and it's not obvious (if you'd asked me before I made this change, I couldn't tell you) what order they're run in. With this change:
becomes:
The user is no longer expected to know that
Isynis a magical thing you can only meaningfully add to (and can be renamed by setting post_target_var on the synapse group) and the injection of current uses the same syntax as current sources.