Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #630 +/- ##
==========================================
- Coverage 88.27% 88.25% -0.02%
==========================================
Files 106 106
Lines 14546 14468 -78
==========================================
- Hits 12840 12769 -71
+ Misses 1706 1699 -7 ☔ View full report in Codecov by Sentry. |
tnowotny
approved these changes
Jul 3, 2024
Member
tnowotny
left a comment
tnowotny
left a comment
There was a problem hiding this comment.
I have to largely trust you on this indexing nightmare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clearly the combination of heterogeneous dendritic delay and batching had never been tested and the indexing code was completely broken. I further parameterised the existing test for dendritic delay to cover this.