missing CodeStream::Scope in Toeplitz code generation#643
Merged
neworderofjamie merged 1 commit intomasterfrom Nov 12, 2024
Merged
missing CodeStream::Scope in Toeplitz code generation#643neworderofjamie merged 1 commit intomasterfrom
neworderofjamie merged 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #643 +/- ##
=======================================
Coverage 87.83% 87.83%
=======================================
Files 104 104
Lines 14103 14104 +1
=======================================
+ Hits 12387 12388 +1
Misses 1716 1716 ☔ View full report in Codecov by Sentry. |
tnowotny
approved these changes
Nov 12, 2024
Member
tnowotny
left a comment
tnowotny
left a comment
There was a problem hiding this comment.
I have to trust you on this one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very subtle as
PresynapticUpdateStrategySIMT::PostSpanToeplitzstill generates valid code as long as there's noaddToPre