Merged
Conversation
…re host component of custom update
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #701 +/- ##
==========================================
- Coverage 88.75% 88.39% -0.37%
==========================================
Files 106 109 +3
Lines 14180 14448 +268
==========================================
+ Hits 12586 12771 +185
- Misses 1594 1677 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnowotny
approved these changes
Aug 27, 2025
Member
tnowotny
left a comment
There was a problem hiding this comment.
It's a bit deep in, but I think I get it, and it is pretty straightforward refactoring.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using custom connectivity updates with host code strings, there was previously no way of measuring their performance. This PR moves the
std::chronobasedTimerhelper class from the single-threaded CPU backend into codeGenUtils for general use and uses this to implement a new per-custom update timer for this code. This can be accessed from C++ viaRuntime::getCustomUpdateHostTimeand from Python viaGeNNModel.get_custom_update_host_timeAlso, based on user feedback, tweaked the documentation to clarify that the 'name' passed to the
GeNNModel.get_custom_update_XXX_timemethods is the name of custom update group not an individual custom update.