Skip to content

Comments

Host timing#701

Merged
neworderofjamie merged 3 commits intomasterfrom
host_timing
Aug 27, 2025
Merged

Host timing#701
neworderofjamie merged 3 commits intomasterfrom
host_timing

Conversation

@neworderofjamie
Copy link
Contributor

@neworderofjamie neworderofjamie commented Aug 8, 2025

When using custom connectivity updates with host code strings, there was previously no way of measuring their performance. This PR moves the std::chrono based Timer helper class from the single-threaded CPU backend into codeGenUtils for general use and uses this to implement a new per-custom update timer for this code. This can be accessed from C++ via Runtime::getCustomUpdateHostTime and from Python via GeNNModel.get_custom_update_host_time

Also, based on user feedback, tweaked the documentation to clarify that the 'name' passed to the GeNNModel.get_custom_update_XXX_time methods is the name of custom update group not an individual custom update.

@codecov
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.39%. Comparing base (80dc278) to head (016c2e4).
⚠️ Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
src/genn/genn/code_generator/codeGenUtils.cc 77.77% 2 Missing ⚠️
pygenn/genn_model.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #701      +/-   ##
==========================================
- Coverage   88.75%   88.39%   -0.37%     
==========================================
  Files         106      109       +3     
  Lines       14180    14448     +268     
==========================================
+ Hits        12586    12771     +185     
- Misses       1594     1677      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit deep in, but I think I get it, and it is pretty straightforward refactoring.

@neworderofjamie neworderofjamie merged commit f44a73e into master Aug 27, 2025
2 of 3 checks passed
@neworderofjamie neworderofjamie deleted the host_timing branch August 27, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants