Skip to content

Fixed really nasty bug#702

Merged
neworderofjamie merged 6 commits intomasterfrom
fix_pretty_print_bug
Aug 11, 2025
Merged

Fixed really nasty bug#702
neworderofjamie merged 6 commits intomasterfrom
fix_pretty_print_bug

Conversation

@neworderofjamie
Copy link
Contributor

@neworderofjamie neworderofjamie commented Aug 11, 2025

I have no idea WHY this was the behaviour but when you call a function from GeNN code e.g.

addSynapse(postInd,  flipKernRow, flipKernCol, preChan, kernOutChan);

in a Toeplitz connectivity initializer, if the first argument wasn't referenced in the function 'body' which gets substituted in (for example if the weight update model only calls addToPre which doesn't care about the postsynaptic neuron ID) then it gives up trying to substitute subsequent arguments.

Also, fixed a small bug relating to using addToPre with procedural connectivity (wrong environment was being used) and added some tests of addToPre with KERNEL weights

@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.81%. Comparing base (80dc278) to head (081dac4).
⚠️ Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   88.75%   88.81%   +0.05%     
==========================================
  Files         106      106              
  Lines       14180    14180              
==========================================
+ Hits        12586    12594       +8     
+ Misses       1594     1586       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@neworderofjamie neworderofjamie marked this pull request as ready for review August 11, 2025 12:27
@neworderofjamie neworderofjamie added this to the GeNN 5.3.0 milestone Aug 11, 2025
Copy link
Member

@tnowotny tnowotny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - nasty bug. Must have been a slip of attention at the time.
Fix seems straightforward.

@neworderofjamie neworderofjamie merged commit b700524 into master Aug 11, 2025
3 checks passed
@neworderofjamie neworderofjamie deleted the fix_pretty_print_bug branch August 11, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants