Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #702 +/- ##
==========================================
+ Coverage 88.75% 88.81% +0.05%
==========================================
Files 106 106
Lines 14180 14180
==========================================
+ Hits 12586 12594 +8
+ Misses 1594 1586 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tnowotny
approved these changes
Aug 11, 2025
Member
tnowotny
left a comment
There was a problem hiding this comment.
I see - nasty bug. Must have been a slip of attention at the time.
Fix seems straightforward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have no idea WHY this was the behaviour but when you call a function from GeNN code e.g.
addSynapse(postInd, flipKernRow, flipKernCol, preChan, kernOutChan);in a Toeplitz connectivity initializer, if the first argument wasn't referenced in the function 'body' which gets substituted in (for example if the weight update model only calls
addToPrewhich doesn't care about the postsynaptic neuron ID) then it gives up trying to substitute subsequent arguments.Also, fixed a small bug relating to using
addToPrewith procedural connectivity (wrong environment was being used) and added some tests ofaddToPrewith KERNEL weights