setup.py: fix macOS dylib packaging and runtime linking#707
Merged
neworderofjamie merged 5 commits intogenn-team:masterfrom Aug 28, 2025
Merged
setup.py: fix macOS dylib packaging and runtime linking#707neworderofjamie merged 5 commits intogenn-team:masterfrom
neworderofjamie merged 5 commits intogenn-team:masterfrom
Conversation
neworderofjamie
requested changes
Aug 27, 2025
Contributor
neworderofjamie
left a comment
There was a problem hiding this comment.
Looks great - just a few minor formatting suggestions
setup.py
Outdated
Comment on lines
125
to
127
| # --- Linux/macOS libffi linkage --- | ||
| if LINUX or MACOS: | ||
| genn_extension_kwargs["libraries"].append("ffi") |
Contributor
There was a problem hiding this comment.
The else clause above (starting at line 115) is basically LINUX or MACOS so I think it would be cleaner to put this logic in there rather than adding yet another if
Co-authored-by: neworderofjamie <neworderofjamie@gmail.com>
Co-authored-by: neworderofjamie <neworderofjamie@gmail.com>
Co-authored-by: neworderofjamie <neworderofjamie@gmail.com>
neworderofjamie
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves cross-platform packaging and installation for
pygenn, with a particular focus on macOS support.Changes Made
package_dataanddependshandling withif / elif / elselogic:.dll.dylib.so.dylibs are copied into the package on macOS.Wl,-rpath,@loader_pathso extensions can locate bundled.dylibs after installation.$ORIGINinruntime_library_dirsso.sos can be found next to the extensions.ffifrom the active environment.if / elif / elsefor clarity.genn_team→genn-team).Impact
.dylibfiles on macOS installs.