tests: check error when pulling recording buffers without recording enabled#737
Open
Atharv-K-979 wants to merge 1 commit intogenn-team:masterfrom
Open
tests: check error when pulling recording buffers without recording enabled#737Atharv-K-979 wants to merge 1 commit intogenn-team:masterfrom
Atharv-K-979 wants to merge 1 commit intogenn-team:masterfrom
Conversation
Atharv-K-979
force-pushed
the
test-presynaptic-kernel-procedural
branch
from
efba36d to
ceda7ee
Compare
Contributor
Author
|
Hi, just a gentle follow-up on this PR whenever you have time. Please let me know if any changes are needed from my side. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change extends the existing recording tests to explicitly cover the
case where recording is not enabled.
Currently, calling
pull_recording_buffers_from_device()without enablingspike or spike-event recording raises an error. This behaviour is intentional,
but was not previously asserted by the test suite.
The new test verifies that this error is raised, ensuring the API contract
remains clear and does not silently change in future.
Test-only change.