Simplify build with TypeScript#7
Merged
kylebarron merged 4 commits intogeoarrow:mainfrom Sep 26, 2023
Merged
Conversation
Contributor
Author
|
BTW, publint is a nice tool to make sure your package is correct for NPM (i.e., exports & main fields are correctly specified): npx publint |
manzt
commented
Sep 26, 2023
| @@ -1 +1 @@ | |||
| export { GeoArrowPointLayer } from "./point.ts.bak"; | |||
| export { GeoArrowPointLayer } from "./point.js"; | |||
Contributor
Author
There was a problem hiding this comment.
The .js extensions are essential for relative imports so that TypeScript compiler will output true ESM. TypeScript won't touch imports, so you need to provide the extension in the output.
kylebarron
reviewed
Sep 26, 2023
| assert, | ||
| } from "@deck.gl/core/typed"; | ||
| import * as arrow from "apache-arrow"; | ||
| import { ScatterplotLayer } from "@deck.gl/layers/typed"; |
Member
There was a problem hiding this comment.
Is there some tool in JS land to auto-sort your imports? would be nice
kylebarron
approved these changes
Sep 26, 2023
Member
|
Amazing, thanks! Excited to try this out! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
tsconfig.jsontomodules/deck.gl-geoarrowdistIf you don't need commonjs or UMD builds, then I'd recommend this setup for simplicity. Otherwise, you can probably use Rollup to support preparing those formats as well.