Now sum DELPDRY in the vertical instead of averaging it when regridding from 72 -> 47 layers#349
Merged
yantosca merged 1 commit intodev/3.12.0from Jan 21, 2026
Merged
Conversation
src/Core/hco_interp_mod.F90 - Added logical variable do_sum, which is set to T if "DELPDRY" is found in the variable name, or F otherwise - Pass do_sum as the 8th argument to routine COLLAPSE - In routine COLLAPSE, set the averaging weights (WGT) to 1 for all levels if do_sum = T. This will sum the variable in the vertical rather than average it. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
yantosca
added
topic: Regridding or Interpolation
yantosca
changed the title
Contributor
Author
|
Integration tests are running |
Contributor
Author
|
All GEOS-Chem Classic integration tests passed: ==============================================================================
GEOS-Chem Classic: Execution Test Results
CodeDir : 4bddc5b GEOS-Chem & HEMCO updates: Merge PR #2946 & PR #336 (7 dust bins )
GEOS-Chem : d65b73ff5 Merge PR #2946 (Add 7 dust bins in GEOS-Chem)
HEMCO : 4def204 Now sum DELPDRY in the vertical instead of averaging it
Cloud-J : 1dff6fe Merge pull request #31 from geoschem/release/8.0.2
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
Using 24 OpenMP threads
Number of execution tests: 38
Submitted as SLURM job: 56094459
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All GEOS-Chem Classic tests were zero-diff w/r/t 14.7.0-rc.0 except
|
Contributor
Author
|
All GCHP integration tests passed: ==============================================================================
GCHP: Execution Test Results
CodeDir : eb66a42 GEOS-Chem & HEMCO updates: Merge PR #2946 & PR #336 (7 dust bins )
MAPL : d1d528e5 Merge pull request #39 from geoschem/feature/mapl_2.55.0
GMAO_Shared : 4ddb3ec Merge pull request #2 from geoschem/feature/mapl-upgrade
ESMA_cmake : bd401dc Merge pull request #8 from yuanjianz/gchp/main
FMS : 259759d1 Merge pull request #3 from geoschem/feature/update_gmao_libs
FVdycoreCubed : 348620f Merge PR #11 (Scale tracers by pressure ratio in first timestep)
geos-chem : d65b73ff5 Merge PR #2946 (Add 7 dust bins in GEOS-Chem)
HEMCO : 4def204 Now sum DELPDRY in the vertical instead of averaging it
Cloud-J : 1dff6fe Merge pull request #31 from geoschem/release/8.0.2
HETP : 2a99b24 Merge pull request #2 from geoschem/bugfix/initialize_local_variables
GFE : bac529f Merge pull request #40 from Goddard-Fortran-Ecosystem/feature/mathomp4/update-gftl-1.15.2
Number of execution tests: 12
Submitted as SLURM job: 56116714
==============================================================================
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
%%% All execution tests passed! %%%
%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%All tests were zero-diff w/r/t |
msulprizio
approved these changes
Jan 21, 2026
Contributor
|
One thing that pops out about the implementation we have (not the fix) is the verbose messages we have within
This bug crept in because this message was buried, and required looking closely at the log even if verbose was on. A robust solution would be to check the units, not the variable name, when determining whether |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Bob Yantosca (Harvard) and Lee Murray (Rochester)
Describe the update
This is the companion PR to geoschem/geos-chem#3170, in which @ltmurray found that
Met_DELPDRYfield was being vertically averaged instead of summed during regridding from 72 -> 47 layers. This led to an incorrect initialization of the stratosphere.Expected changes
The figure above shows stratospheric zonal means for ozone taken from a 72-layer restart file (left), ozone concentrations with the incorrectly-initialized stratosphere (center), and ozone concentrations with the fix in this PR having been applied (right). As you can see, the fixed ozone concentrations in the right panel closely matches the ozone from the 72 layer restart file.
Related Github Issue