feat: add extra metadata for payments (POC)#247
Merged
im-adithya merged 6 commits intomasterfrom May 29, 2025
Merged
Conversation
3 tasks
rolznz
commented
Apr 9, 2025
pages/send/ConfirmPayment.tsx
Outdated
| metadata: { | ||
| recipient_data: { | ||
| identifier: recipientIdentifier, | ||
| description: recipientDescription, |
Contributor
Author
There was a problem hiding this comment.
I think the naming and where description is set here is not great. It comes from the LUD-06 metadata for the invoice. I don't really think this should be in recipient_data?
Contributor
Author
There was a problem hiding this comment.
Maybe just remove this from the PR.
Contributor
Author
|
TODOs:
|
im-adithya
reviewed
May 20, 2025
pages/Transaction.tsx
Outdated
| title="Description" | ||
| content={transaction.description || "-"} | ||
| content={ | ||
| // TODO: should this description be merged on Alby Hub side? |
Member
There was a problem hiding this comment.
I think it is best to keep the description as BOLT11 invoice description and use a separate title and text for metadata related fields.
But I think transaction.description || metadata?.recipient_data?.description || metadata.comment can be used for the tx list to give more context than before.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #246
Closes #203
This adds much more context to the transaction list than was there before (normally you pay to a lightning address and afterwards see an empty transaction with no info about it except the amount)
Needs planning on how the data should be structured, there are some new concepts here. I am just showing what is possible with being able to set metadata when paying. This PR also includes showing a lud-18 payer name for received payments.