Merged
Conversation
fix: Return to QR Scanner on Back from Amount Input
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Has some chores + performance improvements related to Send logic
6bb297c: Removes duplication regarding fixed amount invoices
8608c91: Fixes comment by not allowing if
commentAllowedis07df77e8: Sends directly to lnurl-pay since currently we are fetching lnurl details twice
2760058: Minor naming change as
originalTextwas looking ugly5c93c37: This is to make
Send.tsxlook more readable and also helps this PR to make a new screen for manual entering05b5dab: Replaces Amount button text with Manual (and also replaces icon)
next 6 commits- Described in #307fedd1a3: We were passing
receiverandinvoicetoReceivercomponent for no reason, so I stopped passing that when there's an invoice, so now we do that only when there's an lnurl (we can actually unify that + recipientIdentifier, but will improve that in liightning-tools PR)