Skip to content

fix: improve send logic#308

Merged
im-adithya merged 15 commits intomasterfrom
chore/refactor-send
May 30, 2025
Merged

fix: improve send logic#308
im-adithya merged 15 commits intomasterfrom
chore/refactor-send

Conversation

@im-adithya
Copy link
Copy Markdown
Member

@im-adithya im-adithya commented Apr 10, 2025

Has some chores + performance improvements related to Send logic

6bb297c: Removes duplication regarding fixed amount invoices

8608c91: Fixes comment by not allowing if commentAllowed is 0

7df77e8: Sends directly to lnurl-pay since currently we are fetching lnurl details twice

2760058: Minor naming change as originalText was looking ugly

5c93c37: This is to make Send.tsx look more readable and also helps this PR to make a new screen for manual entering

05b5dab: Replaces Amount button text with Manual (and also replaces icon)

next 6 commits - Described in #307

fedd1a3: We were passing receiver and invoice to Receiver component for no reason, so I stopped passing that when there's an invoice, so now we do that only when there's an lnurl (we can actually unify that + recipientIdentifier, but will improve that in liightning-tools PR)

@im-adithya im-adithya added this to the 1.13.0 milestone May 6, 2025
@im-adithya
Copy link
Copy Markdown
Member Author

This is just a first step. We can improve this further once we use lightning-tools as described in #207, but will tackle that after the release cc @rolznz

@im-adithya im-adithya merged commit 8779fe4 into master May 30, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants