Skip to content

Feat: TTS notifications#323

Merged
im-adithya merged 8 commits intomasterfrom
feat/notification-tts
Jul 24, 2025
Merged

Feat: TTS notifications#323
im-adithya merged 8 commits intomasterfrom
feat/notification-tts

Conversation

@rolznz
Copy link
Copy Markdown
Contributor

@rolznz rolznz commented Jul 16, 2025

From Expo v53 branch

  • add iOS support

@rolznz rolznz changed the title Feat/notification tts Feat: TTS notifications Jul 16, 2025
@im-adithya im-adithya changed the base branch from master to chore/expo-v53 July 18, 2025 12:16
@im-adithya im-adithya changed the base branch from chore/expo-v53 to master July 23, 2025 08:52
@im-adithya
Copy link
Copy Markdown
Member

Now we only have to resolve two things:

  • Decide on "x sats" or "x sats received" or "x sats received on Alby Go" (+ 1 sat? singular/plural too)
  • The spoken notifications toggle gets pushed to the bottom if there are more than one wallets, I left it unchanged as was not sure what was the desired behaviour, I also think we should conditionally show the toggle, i.e. only when notifs are turned on

@im-adithya im-adithya marked this pull request as ready for review July 23, 2025 19:01
@rolznz
Copy link
Copy Markdown
Contributor Author

rolznz commented Jul 24, 2025

@im-adithya I think the two things you mentioned are not that important and can be addressed in a follow-up iteration?

@im-adithya
Copy link
Copy Markdown
Member

Yup, we already have #328 to track it so let's merge this!

@im-adithya im-adithya merged commit bdc9cca into master Jul 24, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants