Skip to content

fix: add scroll view to settings screen #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
im-adithya merged 1 commit into from
Dec 18, 2025
Merged

fix: add scroll view to settings screen #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions components/AlbyBanner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,10 @@ import { ALBY_LIGHTNING_ADDRESS } from "~/lib/constants";
import { initiatePaymentFlow } from "~/lib/initiatePaymentFlow";
import { useAppStore } from "~/lib/state/appStore";
import { useThemeColor } from "~/lib/useThemeColor";
import { cn } from "~/lib/utils";
import { Button } from "./ui/button";

function AlbyBanner() {
function AlbyBanner({ className }: { className?: string }) {
const { shadow } = useThemeColor("shadow");
const lastPayment = useAppStore.getState().getLastAlbyPayment();
const [showBanner, setShowBanner] = useState(
Expand Down Expand Up @@ -39,7 +40,10 @@ function AlbyBanner() {

return (
<View
className="bg-background dark:bg-muted rounded-2xl flex flex-col gap-3 p-4 relative mx-2"
className={cn(
"bg-background dark:bg-muted rounded-2xl flex flex-col gap-3 p-4 relative",
className,
)}
style={{
...Platform.select({
// make sure bg color is applied to avoid RCTView errors
Expand Down
4 changes: 2 additions & 2 deletions pages/Home.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ export function Home() {
showsVerticalScrollIndicator={false}
contentContainerClassName="flex-1 px-6"
>
<View className="flex-1 justify-center gap-8">
<View className="flex-1 justify-center gap-4 sm:gap-8">
<View className="flex items-center justify-center gap-2">
{wallets.length > 1 && (
<TouchableOpacity
Expand Down Expand Up @@ -243,7 +243,7 @@ export function Home() {
)}
</TouchableOpacity>
</View>
{new Date().getDate() === 21 && <AlbyBanner />}
{new Date().getDate() !== 21 && <AlbyBanner />}
</View>
</ScrollView>
<View className="flex items-center justify-center">
Expand Down
Loading
Loading