Skip to content

chore: check password before node start #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rolznz merged 1 commit into from
Aug 4, 2025
Merged

chore: check password before node start #1560

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions http/http_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,12 @@ func (httpSvc *HttpService) startHandler(c echo.Context) error {
})
}

if !httpSvc.cfg.CheckUnlockPassword(startRequest.UnlockPassword) {
Copy link
Copy Markdown
Contributor

@rolznz rolznz Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Internally it also checks, is this to return a better error message?

Copy link
Copy Markdown
Contributor Author

@matjaz matjaz Aug 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, instant feedback + no need to call node start

Copy link
Copy Markdown
Contributor

@rolznz rolznz Aug 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we could do the same with the Wails version. But I don't think it's that important.

Thanks!

return c.JSON(http.StatusUnauthorized, ErrorResponse{
Message: "Invalid password",
})
}

token, err := httpSvc.createJWT(nil)

if err != nil {
Expand Down
Loading