Skip to content

feat: merge app store and connections page#1596

Merged
rolznz merged 29 commits intomasterfrom
feat/merge-app-store-connections
Aug 27, 2025
Merged

feat: merge app store and connections page#1596
rolznz merged 29 commits intomasterfrom
feat/merge-app-store-connections

Conversation

@rolznz
Copy link
Copy Markdown
Contributor

@rolznz rolznz commented Aug 12, 2025

Closes #1548

TODOs:

  • review component inconsistencies with design (tabs, badges) ok for now
  • do we need to merge app detail with the app store page (I think it adds complexity) - added but editing is still done on the show app page
  • implement improved app detail page
  • Re-add the links card (even though you're already connected to the app you might want to visit the site)
  • How to remove the duplication between the app store: and the connection detail:
    • On the app store, if you click on an app that is already installed, go to the app detail of the first connection for that app.
    • If there are multiple connections show a dropdown on the detail page (with the currently selected connection)
  • On app detail page, hide almost everything from the connection details in advanced (id, pubkeys etc)
  • Payment tools and merchant tools should be moved below social media
  • For isolated apps, add a "Balance" card next to total spent, total received, which can have the buttons for top up and draw down
  • For subwallets, add a lightning address card
  • Change top up / draw down to increase/decrease
  • Merge with tw fixes
    • Does dropdown selection work for entire item?
  • Remove unused code in app detail header

@rolznz rolznz requested review from im-adithya and reneaaron August 12, 2025 17:31
@reneaaron
Copy link
Copy Markdown
Contributor

Image

The app details page looks a bit odd with the connection card on top and the space to the right, doesn't it?

@rolznz
Copy link
Copy Markdown
Contributor Author

rolznz commented Aug 14, 2025

@reneaaron yeah, this would be solved if I implement Jakub's real design which merges the app detail properly into the app store app page. I will try to do that (I was hesitant because it duplicates code, but maybe there's a way)

@rolznz rolznz marked this pull request as ready for review August 19, 2025 08:41
Copy link
Copy Markdown
Contributor

@reneaaron reneaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it feels really nice, great job! 💯 Just some minor feedback:

  1. The BuzzPay app looks a bit odd currently:
Image
  1. I still think the "disconnect" button is way too prominent and could be moved into the dropdown

  2. Could we make the permission details (and collapse them by default)? What do you think?

Image

@rolznz
Copy link
Copy Markdown
Contributor Author

rolznz commented Aug 27, 2025

@reneaaron good catch - buzzpay now looks like this:

image

Not that great but maybe ok for a first iteration.

@rolznz rolznz merged commit aae53d6 into master Aug 27, 2025
10 of 11 checks passed
@rolznz rolznz deleted the feat/merge-app-store-connections branch August 27, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement new Connections page design

2 participants