fix: block on payment hash when marking transaction as settled#1878
Merged
fix: block on payment hash when marking transaction as settled#1878
Conversation
Member
|
I couldn't test this as I was still getting single notification on postgres, did you get to reproduce it locally? |
…action-settled-event
Contributor
Author
|
@im-adithya it's hard to reproduce locally as you need to introduce artificial delay in the postgres connection. It's strange you do not get two notifications. How did you test it and which wallet did you pay to? I've tested this by doing a payment to my Blink wallet (2 notifications) then immediately updating my cloud hub to this specific commit and doing another payment to my Blink wallet (I only get 1 notification now) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1874