Skip to content

fix: sub-wallet total spent in subwallet page ui#2106

Merged
rolznz merged 1 commit intomasterfrom
fix/sub-wallet-total-spent
Mar 2, 2026
Merged

fix: sub-wallet total spent in subwallet page ui#2106
rolznz merged 1 commit intomasterfrom
fix/sub-wallet-total-spent

Conversation

@rolznz
Copy link
Copy Markdown
Contributor

@rolznz rolznz commented Mar 2, 2026

fixes #2105

Summary by CodeRabbit

  • Bug Fixes
    • Fixed an issue where transaction fees were not being included in the total spending calculation. The spending total now correctly accounts for all fees paid in transactions.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 2, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4cb794b and f129117.

📒 Files selected for processing (1)
  • frontend/src/components/connections/AppUsage.tsx

📝 Walkthrough

Walkthrough

A minor bug fix modifies the totalSpent calculation in the subwallet component to include transaction fees (feesPaid) alongside the base transaction amount. The computation now sums (amount + feesPaid) / 1000 for outgoing and settled transactions instead of only considering the amount.

Changes

Cohort / File(s) Summary
Fee Inclusion Fix
frontend/src/components/connections/AppUsage.tsx
Updated totalSpent aggregation to include feesPaid in transaction calculations, addressing missing fees in the spending total.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop, hop, the fees now count!
No more hidden costs to amount,
One small tweak, so spry and lean,
The totals now show what they mean.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sub-wallet-total-spent

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rolznz rolznz merged commit b984d7a into master Mar 2, 2026
7 of 12 checks passed
@rolznz rolznz deleted the fix/sub-wallet-total-spent branch March 2, 2026 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Subwallet total spent doesn't include fees

1 participant