fix: remove bitcoin maxi mode and always show crypto actions

[im-adithya]

Fixes #2101

Summary by CodeRabbit

• Removals
  • Removed Bitcoin Maxi Mode setting and its associated toggle from the application.
  • Alternative cryptocurrency options are now consistently visible across deposit, withdrawal, swap, and receive screens.
  • Removed related API fields, configuration options, and backend methods.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e2d26c19-6021-4702-af3e-7f25d9a3c1d9

📥 Commits

Reviewing files that changed from the base of the PR and between 6233904 and 95fb0a6.

📒 Files selected for processing (14)

• api/api.go
• api/models.go
• config/config.go
• config/models.go
• frontend/src/components/CryptoSwapAlert.tsx
• frontend/src/components/PayLightningInvoice.tsx
• frontend/src/hooks/useBitcoinMaxiMode.ts
• frontend/src/screens/onchain/DepositBitcoin.tsx
• frontend/src/screens/settings/Settings.tsx
• frontend/src/screens/wallet/WithdrawOnchainFunds.tsx
• frontend/src/screens/wallet/receive/ReceiveOnchain.tsx
• frontend/src/screens/wallet/swap/index.tsx
• frontend/src/types.ts
• tests/mocks/Config.go

💤 Files with no reviewable changes (9)

• frontend/src/screens/settings/Settings.tsx
• frontend/src/types.ts
• config/models.go
• config/config.go
• frontend/src/hooks/useBitcoinMaxiMode.ts
• tests/mocks/Config.go
• api/models.go
• frontend/src/components/CryptoSwapAlert.tsx
• api/api.go

---

📝 Walkthrough

Walkthrough

This PR removes the Bitcoin Maxi Mode feature from the entire application. The changes systematically delete related API fields, config methods, backend logic, frontend components, hooks, and test mocks across both backend (Go) and frontend (TypeScript/React) layers.

Changes

Cohort / File(s)	Summary
Backend API Layer api/api.go, api/models.go	Removed BitcoinMaxiMode field from InfoResponse and SetBitcoinMaxiMode method from API interface; updated GetInfo and UpdateSettings to eliminate all references.
Backend Config Layer config/config.go, config/models.go	Removed defaultBitcoinMaxiMode constant and GetBitcoinMaxiMode/SetBitcoinMaxiMode methods from both implementation and Config interface.
Frontend Hook frontend/src/hooks/useBitcoinMaxiMode.ts	Deleted the entire useBitcoinMaxiMode hook file that wrapped useInfo to return memoized bitcoinMaxiMode state.
Frontend Components frontend/src/components/CryptoSwapAlert.tsx, frontend/src/components/PayLightningInvoice.tsx, frontend/src/screens/onchain/DepositBitcoin.tsx, frontend/src/screens/settings/Settings.tsx, frontend/src/screens/wallet/WithdrawOnchainFunds.tsx, frontend/src/screens/wallet/receive/ReceiveOnchain.tsx, frontend/src/screens/wallet/swap/index.tsx	Removed useBitcoinMaxiMode hook imports and conditional rendering logic; UI elements now render unconditionally regardless of maxi mode status.
Frontend Type Definitions frontend/src/types.ts	Removed bitcoinMaxiMode boolean property from InfoResponse interface.
Test Mocks tests/mocks/Config.go	Removed GetBitcoinMaxiMode and SetBitcoinMaxiMode mock methods with all associated Call helpers and expecter configurations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat: add fixed float along with bitcoin maxi mode #2094: The PR that originally introduced the Bitcoin Maxi Mode feature, which this PR completely removes across backend and frontend layers.

Suggested reviewers

• reneaaron
• rolznz

Poem

🐰 The maxi mode is bid farewell,
No more bitcoin-only bells,
All the components align anew,
Simpler paths in every view,
Clean removal done with care! 🎯

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly summarizes the primary change: removing Bitcoin Maxi mode and ensuring crypto actions are always displayed.
Linked Issues check	✅ Passed	All changes comprehensively remove BitcoinMaxiMode from backend (config, API, models) and frontend (hooks, components, screens) to fulfill #2101's objective of eliminating maxi mode behavior.
Out of Scope Changes check	✅ Passed	All changes are directly related to removing the BitcoinMaxiMode feature; no unrelated modifications detected across backend configuration, API, and frontend components.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/remove-maxi-mode

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[rolznz]

utACK